From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Berger Subject: [PATCH net-next v2 0/2] net: bcmgenet: fix aborted suspend Date: Mon, 19 Nov 2018 09:56:00 -0800 Message-ID: <1542650162-9229-1-git-send-email-opendmb@gmail.com> Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, YueHaibing , Doug Berger To: "David S. Miller" Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org It is not enough to return an error code from the driver suspend routine. The driver must also restore the device functionality. This commit corrects the issue introduced by commit 0db55093b566 ("net: bcmgenet: return correct value 'ret' from bcmgenet_power_down") by calling the driver resume function if the suspend function returns an error. Changes in v2: - Removed accidentally included write to HFB register Doug Berger (2): net: bcmgenet: code movement net: bcmgenet: abort suspend on error drivers/net/ethernet/broadcom/genet/bcmgenet.c | 63 +++++++++++----------- drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c | 2 + 2 files changed, 35 insertions(+), 30 deletions(-) -- 2.7.4