From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan Whitehead Subject: [PATCH v1 net] lan743x: fix return value for lan743x_tx_napi_poll Date: Tue, 20 Nov 2018 13:26:43 -0500 Message-ID: <1542738403-23034-1-git-send-email-Bryan.Whitehead@microchip.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , To: Return-path: Received: from esa6.microchip.iphmx.com ([216.71.154.253]:5655 "EHLO esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbeKUFDq (ORCPT ); Wed, 21 Nov 2018 00:03:46 -0500 Sender: netdev-owner@vger.kernel.org List-ID: It has been noticed that under stress the lan743x driver will sometimes hang or cause a kernel panic. It has been noticed that returning '0' instead of 'weight' fixes this issue. fixes: rare kernel panic under heavy traffic load. Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index 867cddb..ca33ade 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -1672,7 +1672,7 @@ static int lan743x_tx_napi_poll(struct napi_struct *napi, int weight) netif_wake_queue(adapter->netdev); } - if (!napi_complete_done(napi, weight)) + if (!napi_complete_done(napi, 0)) goto done; /* enable isr */ @@ -1681,7 +1681,7 @@ static int lan743x_tx_napi_poll(struct napi_struct *napi, int weight) lan743x_csr_read(adapter, INT_STS); done: - return weight; + return 0; } static void lan743x_tx_ring_cleanup(struct lan743x_tx *tx) -- 2.7.4