From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: [PATCH v4 net-next 2/6] net: dsa: microchip: clean up code Date: Tue, 20 Nov 2018 15:55:06 -0800 Message-ID: <1542758110-1037-3-git-send-email-Tristram.Ha@microchip.com> References: <1542758110-1037-1-git-send-email-Tristram.Ha@microchip.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Tristram Ha , Andrew Lunn , Florian Fainelli , Pavel Machek , , To: "David S. Miller" Return-path: Received: from esa4.microchip.iphmx.com ([68.232.154.123]:65513 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726794AbeKUK07 (ORCPT ); Wed, 21 Nov 2018 05:26:59 -0500 In-Reply-To: <1542758110-1037-1-git-send-email-Tristram.Ha@microchip.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Tristram Ha Clean up code according to patch check suggestions. Signed-off-by: Tristram Ha Reviewed-by: Woojung Huh Reviewed-by: Pavel Machek Reviewed-by: Florian Fainelli Reviewed-by: Andrew Lunn --- drivers/net/dsa/microchip/ksz_common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index d47d03b..eb833df 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -890,9 +890,9 @@ static void ksz_port_mdb_add(struct dsa_switch *ds, int port, if (static_table[0] & ALU_V_STATIC_VALID) { /* check this has same vid & mac address */ - if (((static_table[2] >> ALU_V_FID_S) == (mdb->vid)) && + if (((static_table[2] >> ALU_V_FID_S) == mdb->vid) && ((static_table[2] & ALU_V_MAC_ADDR_HI) == mac_hi) && - (static_table[3] == mac_lo)) { + static_table[3] == mac_lo) { /* found matching one */ break; } @@ -963,9 +963,9 @@ static int ksz_port_mdb_del(struct dsa_switch *ds, int port, if (static_table[0] & ALU_V_STATIC_VALID) { /* check this has same vid & mac address */ - if (((static_table[2] >> ALU_V_FID_S) == (mdb->vid)) && + if (((static_table[2] >> ALU_V_FID_S) == mdb->vid) && ((static_table[2] & ALU_V_MAC_ADDR_HI) == mac_hi) && - (static_table[3] == mac_lo)) { + static_table[3] == mac_lo) { /* found matching one */ break; } -- 1.9.1