netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pkshih <pkshih@realtek.com>
To: "kai.heng.feng@canonical.com" <kai.heng.feng@canonical.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: Fix non-working BSS STA mode
Date: Thu, 13 Dec 2018 00:35:47 +0000	[thread overview]
Message-ID: <1544661346.2548.2.camel@realtek.com> (raw)
In-Reply-To: <20181212051335.22580-1-kai.heng.feng@canonical.com>

On Wed, 2018-12-12 at 13:13 +0800, Kai-Heng Feng wrote:
> Once BSS STA mode gets started, it can be scanned by other clients but
> cannot entablish a connection.
         ^^^ typo: establish
> 
> Turns out the set_bcn_reg() and its *_set_beacon_related_registers()
> callbacks never get called so it has problem beaconing.
> 
> Enable the function in rtl_op_bss_info_changed() can make BSS STA mode
> start to work.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c
> b/drivers/net/wireless/realtek/rtlwifi/core.c
> index 4bf7967590ca..11d27a5cc576 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -1054,7 +1054,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw
> *hw,
>  					 "BSS_CHANGED_BEACON_ENABLED\n");
>  
>  				/*start hw beacon interrupt. */
> -				/*rtlpriv->cfg->ops->set_bcn_reg(hw); */
> +				rtlpriv->cfg->ops->set_bcn_reg(hw);
>  				mac->beacon_enabled = 1;
>  				rtlpriv->cfg->ops->update_interrupt_mask(hw,
>  						rtlpriv->cfg->maps

Which wifi chip do you use? And, please share your test scenario.

Thanks


  reply	other threads:[~2018-12-13  0:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12  5:13 [PATCH] rtlwifi: Fix non-working BSS STA mode Kai-Heng Feng
2018-12-13  0:35 ` Pkshih [this message]
2018-12-13  5:36   ` Kai Heng Feng
2018-12-13  7:39     ` Pkshih
2018-12-13  8:03       ` Kai Heng Feng
2018-12-20  6:42 ` Kalle Valo
2018-12-20 12:56   ` Kai Heng Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1544661346.2548.2.camel@realtek.com \
    --to=pkshih@realtek.com \
    --cc=davem@davemloft.net \
    --cc=kai.heng.feng@canonical.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).