From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH iproute2 3/4] tests: delete dummy interface after default route test Date: Sun, 16 Dec 2018 13:52:26 +0000 Message-ID: <1544968346.4766.3.camel@debian.org> References: <20181215153051.13166-1-bluca@debian.org> <20181215153051.13166-3-bluca@debian.org> <20181215163250.GA29950@x230> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-a+QljZ27BLkYg7CzTF4F" Cc: netdev@vger.kernel.org, stephen@networkplumber.org To: Petr Vorel Return-path: Received: from mail-wm1-f67.google.com ([209.85.128.67]:50754 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730382AbeLPNwb (ORCPT ); Sun, 16 Dec 2018 08:52:31 -0500 Received: by mail-wm1-f67.google.com with SMTP id n190so9854936wmd.0 for ; Sun, 16 Dec 2018 05:52:28 -0800 (PST) In-Reply-To: <20181215163250.GA29950@x230> Sender: netdev-owner@vger.kernel.org List-ID: --=-a+QljZ27BLkYg7CzTF4F Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2018-12-15 at 17:32 +0100, Petr Vorel wrote: > Hi Luca, >=20 > > Signed-off-by: Luca Boccassi >=20 > Reviewed-by: Petr Vorel > > --- > > =C2=A0testsuite/tests/ip/route/add_default_route.t | 2 ++ > > =C2=A01 file changed, 2 insertions(+) > > diff --git a/testsuite/tests/ip/route/add_default_route.t > > b/testsuite/tests/ip/route/add_default_route.t > > index 569ba1f8..c536e35f 100755 > > --- a/testsuite/tests/ip/route/add_default_route.t > > +++ b/testsuite/tests/ip/route/add_default_route.t > > @@ -31,3 +31,5 @@ ts_ip "$0" "Add another IPv6 route dst > > cafe:babe::/64" -6 route add cafe:babe::/ > > =C2=A0ts_ip "$0" "Show IPv6 default route" -6 route show default > > =C2=A0test_on "default via dead:beef::2 dev $DEV" > > =C2=A0test_lines_count 1 > > + > > +ts_ip "$0" "Del $NEW_DEV dummy interface"=C2=A0=C2=A0link del dev $DEV >=20 > Shouldn't this be using $DEV instead of $NEW_DEV? > ts_ip "$0" "Delete $DEV interface" link del dev $DEV >=20 > Copy paste from new_link.t? Ops! Yes indeed, copy-pasta, fixed in v2, thanks. --=20 Kind regards, Luca Boccassi --=-a+QljZ27BLkYg7CzTF4F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlwWWJoACgkQSylmgFB4 UWJ8eggAgz1K3rRs7x+5cxl08Ow8E3X8NPW6aXq1cIeVRum4RlV+tbsObIGBuGHD cWN6WSTPbDn06DKmp/f9/X4Hudp303vsTrYnkn7T2+oT59thbif1NDcA5R8KZffz F/M8slJZ7CQJaoszirVm0RElp5NSmA5eHwqqwaDpnc3OMSGVj8tBdUgzBBPTE2GF 4c4b5MBa9+9UNz0QXtQi+Kt9W3EmPRIBNalrGLi9Ee/VzdegPioqpwHp9FdTcVrL yrRgWS2hZ7bzR6dJ1wF+xUehWy5/E1Ve3K4zfxIdJLve1NicNnbDx9cDg0BuqADd nogi5DwlWmVw2xiuyM2TcDHnluuTDQ== =IH5a -----END PGP SIGNATURE----- --=-a+QljZ27BLkYg7CzTF4F--