From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test
 loads them
Date: Sun, 16 Dec 2018 20:57:21 +0000
Message-ID: <1544993841.4766.5.camel@debian.org>
References: <20181215153051.13166-1-bluca@debian.org>
         <20181216134727.8342-1-bluca@debian.org>
         <20181216134727.8342-4-bluca@debian.org> <20181216202117.GB6090@x230>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-+DOO/CCiv1cr57S+2kaX"
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
        petr.vorel@gmail.com
To: Petr Vorel <pvorel@suse.cz>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f66.google.com ([209.85.221.66]:39826 "EHLO
        mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730758AbeLPU5Z (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 16 Dec 2018 15:57:25 -0500
Received: by mail-wr1-f66.google.com with SMTP id t27so10298948wra.6
        for <netdev@vger.kernel.org>; Sun, 16 Dec 2018 12:57:23 -0800 (PST)
In-Reply-To: <20181216202117.GB6090@x230>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--=-+DOO/CCiv1cr57S+2kaX
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2018-12-16 at 21:21 +0100, Petr Vorel wrote:
> Hi Luca,
>=20
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> LGTM, but I'd suggest 2 small changes (see bellow).
>=20
> > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t
> > =C2=A0TUNNEL_NAME=3D"tunnel_test_ip"
>=20
> I'd put KMODS here:
> KMODS=3D"ip6_gre ip6_tunnel ip_gre ip_tunnel gre"
>=20
> The reason is maintenance of this script - maybe one day there will
> be other
> modules needed to be added, take this list as a configuration (which
> is usually
> in shell scripts in the top).
> BTW Maintenance was reason why I didn't like duplicity in modules you
> had in v1.
>=20
> > +# unload kernel modules to remove dummy interfaces only if they
> > were not in use beforehand
> > +KMODS_REMOVE=3D
>=20
> As a side effect, this could be lower case (showing it's not a
> configuration
> variable, but just normal variable).

Ok, thanks, done both in v3.

--=20
Kind regards,
Luca Boccassi
--=-+DOO/CCiv1cr57S+2kaX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlwWvDEACgkQSylmgFB4
UWKc2AgAod4VWmnijM0IWyNJp91MUM4e3iKKR0PddPg6FYLM55QYcnrnlY5vAzS5
Bsxh/Mexe6sltuukgAqfznDd904TgT03kT1jMkoGdifocMJb8FW4iqlxLbypgi2T
oGevigDnZUu79/pVSn8ReTwunysZZ3exYHiGgmoMQ7yQzhvZlAW4NTsYCgO26RyL
9Odh3Ao7Y3UcDJWsK/J4aYiF3IrNA0YNhjxNR3AVjogg+OQcAzpAf+EbJK0dUYCg
U7f8yVNS2sqfzAAAIO4qx8vLx8/jRGPiWxgR0XS7pYMNuiv/QMO5WEm5VuB617C7
EW9QVQmI+INKVNgFvq+pp1UyUS4ZQQ==
=4nTQ
-----END PGP SIGNATURE-----

--=-+DOO/CCiv1cr57S+2kaX--