From: Bart Van Assche <bvanassche@acm.org>
To: David Miller <davem@davemloft.net>
Cc: tgraf@suug.ch, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/rhashtable: Fix work initialization in rhashtable_init()
Date: Thu, 20 Dec 2018 09:51:27 -0800 [thread overview]
Message-ID: <1545328287.185366.501.camel@acm.org> (raw)
In-Reply-To: <20181218.213257.1251094090416839024.davem@davemloft.net>
On Tue, 2018-12-18 at 21:32 -0800, David Miller wrote:
> From: Bart Van Assche <bvanassche@acm.org>
> Date: Mon, 17 Dec 2018 13:40:58 -0800
>
> > The test_insert_dup() function from lib/test_rhashtable.c passes a
> > pointer to a stack object to rhltable_init(). Avoid that the following
> > is reported with object debugging enabled while running the selftest
> > from lib/test_rhashtable.c:
> ...
> > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>
> Please just fix the test to use the global object created for this purpose
> instead of an unnecessary on-stack instance.
Hi Dave,
I will do that. Thanks for the feedback.
Bart.
prev parent reply other threads:[~2018-12-20 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 21:40 [PATCH] lib/rhashtable: Fix work initialization in rhashtable_init() Bart Van Assche
2018-12-19 5:32 ` David Miller
2018-12-20 17:51 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545328287.185366.501.camel@acm.org \
--to=bvanassche@acm.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).