From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH] lib/rhashtable: Fix work initialization in rhashtable_init() Date: Thu, 20 Dec 2018 09:51:27 -0800 Message-ID: <1545328287.185366.501.camel@acm.org> References: <20181217214058.76811-1-bvanassche@acm.org> <20181218.213257.1251094090416839024.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-7" Content-Transfer-Encoding: 7bit Cc: tgraf@suug.ch, herbert@gondor.apana.org.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20181218.213257.1251094090416839024.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2018-12-18 at 21:32 -0800, David Miller wrote: +AD4 From: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 +AD4 Date: Mon, 17 Dec 2018 13:40:58 -0800 +AD4 +AD4 +AD4 The test+AF8-insert+AF8-dup() function from lib/test+AF8-rhashtable.c passes a +AD4 +AD4 pointer to a stack object to rhltable+AF8-init(). Avoid that the following +AD4 +AD4 is reported with object debugging enabled while running the selftest +AD4 +AD4 from lib/test+AF8-rhashtable.c: +AD4 ... +AD4 +AD4 Signed-off-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 +AD4 +AD4 Please just fix the test to use the global object created for this purpose +AD4 instead of an unnecessary on-stack instance. Hi Dave, I will do that. Thanks for the feedback. Bart.