From: William Tu <u9012063@gmail.com>
To: bjorn.topel@gmail.com, magnus.karlsson@gmail.com, ast@kernel.org,
daniel@iogearbox.net, netdev@vger.kernel.org,
makita.toshiaki@lab.ntt.co.jp, yihung.wei@gmail.com,
magnus.karlsson@intel.com
Subject: [PATCH bpf-next RFCv3 5/6] veth: add AF_XDP RX support.
Date: Wed, 26 Dec 2018 12:27:52 -0800 [thread overview]
Message-ID: <1545856073-8680-6-git-send-email-u9012063@gmail.com> (raw)
In-Reply-To: <1545856073-8680-1-git-send-email-u9012063@gmail.com>
If the receiving veth side has umem rx enabled, the patch
directly copy the packet from the peer side's send buffer
to the umem receive buffer. This requires running AF_XDP
as both side of the veth peer. For example:
Receiver:
# ip netns exec at_ns0 xdpsock -r -N -z -i p0
Sender:
# xdpsock -i p1 -t -N -z
The performance increases from 1.4Mpps to 2.3Mpps.
Signed-off-by: William Tu <u9012063@gmail.com>
---
drivers/net/veth.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 551444195398..8aac67554880 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -766,11 +766,28 @@ static int veth_xsk_poll(struct napi_struct *napi, int budget)
struct sk_buff *skb;
struct page *page;
void *vaddr;
+ u64 handle;
u32 len;
if (!xsk_umem_consume_tx_virtual(peer_rq->xsk_umem, &vaddr, &len))
break;
+ if (rq->xsk_umem && xsk_umem_peek_addr(rq->xsk_umem, &handle)) {
+ char *daddr;
+ u64 hr = 0;
+
+ /* the peer side also has umem enabled,
+ * copy directly to it.
+ */
+ handle &= rq->xsk_umem->chunk_mask;
+ hr = rq->xsk_umem->headroom + XDP_PACKET_HEADROOM;
+ daddr = xdp_umem_get_data(rq->xsk_umem, handle);
+ daddr += hr;
+ memcpy((void *)daddr, vaddr, len);
+ xsk_umem_discard_addr(rq->xsk_umem);
+ vaddr = daddr;
+ }
+
xdpf.data = vaddr + metasize;
xdpf.len = len;
xdpf.headroom = 0;
--
2.7.4
next prev parent reply other threads:[~2018-12-26 20:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 20:27 [PATCH bpf-next RFCv3 0/6] AF_XDP support for veth William Tu
2018-12-26 20:27 ` [PATCH bpf-next RFCv3 1/6] xsk: add xsk_umem_consume_tx_virtual William Tu
2018-12-26 20:27 ` [PATCH bpf-next RFCv3 2/6] veth: support AF_XDP TX copy-mode William Tu
2019-01-01 13:44 ` Toshiaki Makita
2019-01-05 15:55 ` William Tu
2019-01-08 7:25 ` Toshiaki Makita
2018-12-26 20:27 ` [PATCH bpf-next RFCv3 3/6] xsk: add new MEM type for virtual device William Tu
2018-12-26 20:27 ` [PATCH bpf-next RFCv3 4/6] veth: add zero-copy AF_XDP TX support William Tu
2018-12-26 20:27 ` William Tu [this message]
2018-12-26 20:27 ` [PATCH bpf-next RFCv3 6/6] samples: bpf: add veth AF_XDP example William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545856073-8680-6-git-send-email-u9012063@gmail.com \
--to=u9012063@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=yihung.wei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).