From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F346C282CA for ; Sun, 27 Jan 2019 15:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BF0D214D8 for ; Sun, 27 Jan 2019 15:53:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Iklyvxxn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726857AbfA0PxY (ORCPT ); Sun, 27 Jan 2019 10:53:24 -0500 Received: from m12-14.163.com ([220.181.12.14]:37727 "EHLO m12-14.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbfA0PxY (ORCPT ); Sun, 27 Jan 2019 10:53:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=Fyeh90qkeFSiUB1WtK DTgdbkuFZd0pau+OrfJ/aPIEo=; b=Iklyvxxn4K3J6Rk/zMff056sXXXALV1AhU 0dC+LAA35h73F9zbS+zC84E7KFdeog0bUkkPN157VkVXif4gQNYtDBRHfkxhTnb2 Lyr+Q1Fnc8DAmrkIE3p7XcpPZHPel5C5X92JzzOaIPURpDPtVwisKRBrRQ7eOy92 zTM0fpEXE= Received: from yangwei-T440.lan (unknown [182.138.181.126]) by smtp10 (Coremail) with SMTP id DsCowAAngQ_m001comxuDQ--.47678S3; Sun, 27 Jan 2019 23:53:10 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, Yang Wei Subject: [PATCH V2] net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq Date: Sun, 27 Jan 2019 23:53:08 +0800 Message-Id: <1548604388-4087-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DsCowAAngQ_m001comxuDQ--.47678S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XryDGw4DCw4xtrW5ur17Jrb_yoW3Grb_ur 109F4xXw45Cr90gw109r4rua4F93Z5XrW8AayxK3yrA39rWF15Jw1Durn7Gr1rWws8AF9F vr9IvFZ8Z343ZjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRico7tUUUUU== X-Originating-IP: [182.138.181.126] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/xtbB0wdJolXlifoKvgAAsI Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org dev_consume_skb_irq() should be called in i596_interrupt() when xmit done. It makes drop profiles more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/i825xx/82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/82596.c b/drivers/net/ethernet/i825xx/82596.c index d719668..855900a 100644 --- a/drivers/net/ethernet/i825xx/82596.c +++ b/drivers/net/ethernet/i825xx/82596.c @@ -1310,7 +1310,7 @@ static irqreturn_t i596_interrupt(int irq, void *dev_id) dev->stats.tx_aborted_errors++; } - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); tx_cmd->cmd.command = 0; /* Mark free */ break; -- 2.7.4