From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B674C282C8 for ; Mon, 28 Jan 2019 14:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 200082171F for ; Mon, 28 Jan 2019 14:42:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="EMELJ5o4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbfA1Omr (ORCPT ); Mon, 28 Jan 2019 09:42:47 -0500 Received: from m12-17.163.com ([220.181.12.17]:45017 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726266AbfA1Omr (ORCPT ); Mon, 28 Jan 2019 09:42:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=vbFJ6SgRIRCcu+y99V diYDXP/UsHTuY3rR2ZO9nFNIM=; b=EMELJ5o4attmB2kLWF4/tga483zdwDDlgS Wj2fLe4V3A4QMcjlEj6PMbBCfxz6By1voTk2rmPJU+GX20WRJ0f83+2vHGCN1+iw YZM23mRyvhLY/KFvPPXwhXQmTQ5gwngZvID/pSRN25Y9j0JtA5TwM0cwwf5K5YVh B9fbddvkc= Received: from yangwei-T440.lan (unknown [182.138.181.126]) by smtp13 (Coremail) with SMTP id EcCowAAHzc3SFE9cm5kzDg--.21004S3; Mon, 28 Jan 2019 22:42:27 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org, davem@davemloft.net Cc: andrew@lunn.ch, Yang Wei Subject: [PATCH net V2] net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Mon, 28 Jan 2019 22:42:25 +0800 Message-Id: <1548686545-4580-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: EcCowAAHzc3SFE9cm5kzDg--.21004S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XryDGw4DZryUtw13uFyUKFg_yoW3XFX_Wr 1I9r1xXw45Crn0gw40kF45Aa4F93WrXrW8A3W2g3yrA39rWF15Jw1Durn7Gr1rWrs8AF9F 9r9IvFWDZ342yjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbVbkUUUUUU== X-Originating-IP: [182.138.181.126] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiERNKolWBj-3TyAAAsX Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org dev_consume_skb_irq() should be called in i596_interrupt() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/i825xx/82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/82596.c b/drivers/net/ethernet/i825xx/82596.c index d719668..855900a 100644 --- a/drivers/net/ethernet/i825xx/82596.c +++ b/drivers/net/ethernet/i825xx/82596.c @@ -1310,7 +1310,7 @@ static irqreturn_t i596_interrupt(int irq, void *dev_id) dev->stats.tx_aborted_errors++; } - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); tx_cmd->cmd.command = 0; /* Mark free */ break; -- 2.7.4