From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF83C169C4 for ; Tue, 29 Jan 2019 14:41:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCC50214DA for ; Tue, 29 Jan 2019 14:41:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="LQ5MmmGV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726016AbfA2OlF (ORCPT ); Tue, 29 Jan 2019 09:41:05 -0500 Received: from m12-17.163.com ([220.181.12.17]:56016 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725769AbfA2OlF (ORCPT ); Tue, 29 Jan 2019 09:41:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=VvMeAl+6HB0FOKLUw/ g/aq4RjQJoGIbOj+y8yw3TCJQ=; b=LQ5MmmGVZUzt3wk70liiQy5XCWAZ9MEi1A 25GFJTiWLv7SNh8t1W4o/rk4ACUQjeXfpPnTGHV+p2Q8DsuwZrAvQlhQDPlOv42i Y1TwhceRtQkTeciVT0nKGz6trBI4KBEIIXrtdWpNBbb4W2YQmJ6TRrgPWkm2Q3mt dSvp1VqJo= Received: from yangwei-T440.lan (unknown [182.138.181.126]) by smtp13 (Coremail) with SMTP id EcCowABXj8r0ZVBcVfu2Dg--.26293S3; Tue, 29 Jan 2019 22:40:53 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn Subject: [PATCH net] net: 8139cp: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Tue, 29 Jan 2019 22:40:51 +0800 Message-Id: <1548772851-4692-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: EcCowABXj8r0ZVBcVfu2Dg--.26293S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF4UGw4DAr13Jr43Jrb_yoW3WFXE9w 1av3Z7Jw45Jr1Ykw1Dta1Yy3yFvr1DXw4rZFyxt3yay347tF1UAr18Zrn3GryxGw4kZFy7 Jr9FqrsrC3y0qjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0c18DUUUUU== X-Originating-IP: [182.138.181.126] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiRRVLoll9ond0wgAAs+ Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in cp_tx() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/realtek/8139cp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c index 44f6e48..4f910c4 100644 --- a/drivers/net/ethernet/realtek/8139cp.c +++ b/drivers/net/ethernet/realtek/8139cp.c @@ -691,7 +691,7 @@ static void cp_tx (struct cp_private *cp) } bytes_compl += skb->len; pkts_compl++; - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); } cp->tx_skb[tx_tail] = NULL; -- 2.7.4