From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA1CC282C7 for ; Tue, 29 Jan 2019 15:05:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B63732175B for ; Tue, 29 Jan 2019 15:05:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="HFl7mQR7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728817AbfA2PF1 (ORCPT ); Tue, 29 Jan 2019 10:05:27 -0500 Received: from m12-11.163.com ([220.181.12.11]:46771 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728219AbfA2PF0 (ORCPT ); Tue, 29 Jan 2019 10:05:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=FNju5Ho6x3Bs8hNi/w RWN2wuywrop+qqBQO/qXXtMWo=; b=HFl7mQR7CzdaqkJRLr2BJt45GusFTrlqKE VkwP+hCgT7QkSrim270RpMf9FcQxsCvCIGNFIP1PYpXoUIY0ZOg5VjcMlCXAOprP nNmncNMqND48t0jSPOpZZ7+m+9SPFZ6S5V4htp5YIYQQuZgSg7u20yM4pXoEMaTR Q1w9wAFhg= Received: from yangwei-T440.lan (unknown [182.138.181.126]) by smtp7 (Coremail) with SMTP id C8CowADHqRCJa1BcmUMODg--.45298S3; Tue, 29 Jan 2019 23:04:42 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: michael.chan@broadcom.com, davem@davemloft.net, yang.wei9@zte.com.cn Subject: [PATCH net] net: b44: replace dev_kfree_skb_xxx by dev_consume_skb_xxx for drop profiles Date: Tue, 29 Jan 2019 23:04:40 +0800 Message-Id: <1548774280-5757-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: C8CowADHqRCJa1BcmUMODg--.45298S3 X-Coremail-Antispam: 1Uf129KBjvJXoWrtFW8AF1rJr17tr48ury5XFb_yoW8Jry7pa 1DW34DCrWkJr4YqayUGay7XFnIqayrtFWfWFW3C3WfZr98AryqgF40gFyavws8Zrs5CFy2 yr42yF93tFZ8Ar7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jTFALUUUUU= X-Originating-IP: [182.138.181.126] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiRRVLoll9ond0wgABs- Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei The skb should be freed by dev_consume_skb_any() in b44_start_xmit() when bounce_skb is used. The skb is be replaced by bounce_skb, so the original skb should be consumed(not drop). dev_consume_skb_irq() should be called in b44_tx() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/broadcom/b44.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c index f448089..97ab0dd 100644 --- a/drivers/net/ethernet/broadcom/b44.c +++ b/drivers/net/ethernet/broadcom/b44.c @@ -638,7 +638,7 @@ static void b44_tx(struct b44 *bp) bytes_compl += skb->len; pkts_compl++; - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); } netdev_completed_queue(bp->dev, pkts_compl, bytes_compl); @@ -1012,7 +1012,7 @@ static netdev_tx_t b44_start_xmit(struct sk_buff *skb, struct net_device *dev) } skb_copy_from_linear_data(skb, skb_put(bounce_skb, len), len); - dev_kfree_skb_any(skb); + dev_consume_skb_any(skb); skb = bounce_skb; } -- 2.7.4