From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D29BC169C4 for ; Tue, 29 Jan 2019 15:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1127321473 for ; Tue, 29 Jan 2019 15:32:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="ExxxsqxT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728117AbfA2Pct (ORCPT ); Tue, 29 Jan 2019 10:32:49 -0500 Received: from m12-15.163.com ([220.181.12.15]:48925 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfA2Pcs (ORCPT ); Tue, 29 Jan 2019 10:32:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=GTSa1t4/EXbAs9bvTF 8foC0S7g1yUirCcTBzrSpLReU=; b=ExxxsqxTjPB5h+gLVYZqgPZHExgJzmSUKW 1MrEKiYJgRRs5vFhsBxvssVYstczGSd5BQJqK07Jvtfb9/qiSjrG1e3zO9UyqXNV hnrherYssPH5qBNYWuapU3h4SNb6oYMUz3pYms+2Zocm5ttllX/iey0LX4kSzmjL KgEiB3dhE= Received: from yangwei-T440.lan (unknown [182.138.181.126]) by smtp11 (Coremail) with SMTP id D8CowAA3n1MPclBcPmXsBA--.47820S3; Tue, 29 Jan 2019 23:32:32 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: dmitry.tarnyagin@lockless.no, davem@davemloft.net, yang.wei9@zte.com.cn Subject: [PATCH net] net: caif: call dev_consume_skb_any when skb xmit done Date: Tue, 29 Jan 2019 23:32:22 +0800 Message-Id: <1548775942-6476-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: D8CowAA3n1MPclBcPmXsBA--.47820S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtFW8Jw15ZF48GrW8KF4fuFg_yoWfZrX_Cr 18Jw42qa1UCr15Kw17Ka1YvFyFvrWDXrW8ZFyxtrW3Wa47Xrn8ArsIvr9xK34rWw4FqF17 WF9xu392qrW7ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0dpnPUUUUU== X-Originating-IP: [182.138.181.126] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiShxLolPAC1AStAAAsR Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei The skb shouled be consumed when xmit done, it makes drop profiles (dropwatch, perf) more friendly. dev_kfree_skb_irq()/kfree_skb() shouled be replaced by dev_consume_skb_any(), it makes code cleaner. Signed-off-by: Yang Wei --- drivers/net/caif/caif_serial.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c index a0f954f..44e6c7b 100644 --- a/drivers/net/caif/caif_serial.c +++ b/drivers/net/caif/caif_serial.c @@ -257,10 +257,7 @@ static int handle_tx(struct ser_device *ser) if (skb->len == 0) { struct sk_buff *tmp = skb_dequeue(&ser->head); WARN_ON(tmp != skb); - if (in_interrupt()) - dev_kfree_skb_irq(skb); - else - kfree_skb(skb); + dev_consume_skb_any(skb); } } /* Send flow off if queue is empty */ -- 2.7.4