Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'

Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'

[YueHaibing]

+cc netdev@vger.kernel.org

On 2019/1/29 13:57, YueHaibing wrote:
> ping...
> 
> On 2018/9/11 20:12, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/realtek/rtlwifi/base.c: In function 'rtl_c2h_content_parsing':
>> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
>>  variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  drivers/net/wireless/realtek/rtlwifi/base.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
>> index f4122c8..92b6918 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -2310,11 +2310,10 @@ static void rtl_c2h_content_parsing(struct ieee80211_hw *hw,
>>  	struct rtl_priv *rtlpriv = rtl_priv(hw);
>>  	struct rtl_hal_ops *hal_ops = rtlpriv->cfg->ops;
>>  	const struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops;
>> -	u8 cmd_id, cmd_seq, cmd_len;
>> +	u8 cmd_id, cmd_len;
>>  	u8 *cmd_buf = NULL;
>>  
>>  	cmd_id = GET_C2H_CMD_ID(skb->data);
>> -	cmd_seq = GET_C2H_SEQ(skb->data);
>>  	cmd_len = skb->len - C2H_DATA_OFFSET;
>>  	cmd_buf = GET_C2H_DATA_PTR(skb->data);
>>
>>
>> .
>>

Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'

[Pkshih]

On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote:
> +cc netdev@vger.kernel.org
> 
> On 2019/1/29 13:57, YueHaibing wrote:
> > ping...
> > 
> > On 2018/9/11 20:12, YueHaibing wrote:
> >> Fixes gcc '-Wunused-but-set-variable' warning:
> >>
> >> drivers/net/wireless/realtek/rtlwifi/base.c: In function
> 'rtl_c2h_content_parsing':
> >> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
> >>  variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
> >>
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thanks for your fix.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>


> >> ---
> >>  drivers/net/wireless/realtek/rtlwifi/base.c | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c
> b/drivers/net/wireless/realtek/rtlwifi/base.c
> >> index f4122c8..92b6918 100644
> >> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> >> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> >> @@ -2310,11 +2310,10 @@ static void rtl_c2h_content_parsing(struct
> ieee80211_hw *hw,
> >>  	struct rtl_priv *rtlpriv = rtl_priv(hw);
> >>  	struct rtl_hal_ops *hal_ops = rtlpriv->cfg->ops;
> >>  	const struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops;
> >> -	u8 cmd_id, cmd_seq, cmd_len;
> >> +	u8 cmd_id, cmd_len;
> >>  	u8 *cmd_buf = NULL;
> >>  
> >>  	cmd_id = GET_C2H_CMD_ID(skb->data);
> >> -	cmd_seq = GET_C2H_SEQ(skb->data);
> >>  	cmd_len = skb->len - C2H_DATA_OFFSET;
> >>  	cmd_buf = GET_C2H_DATA_PTR(skb->data);
> >>
> >>
> >> .
> 

Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'

[Kalle Valo]

Pkshih <pkshih@realtek.com> writes:

> On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote:
>> +cc netdev@vger.kernel.org
>> 
>> On 2019/1/29 13:57, YueHaibing wrote:
>> > ping...
>> > 
>> > On 2018/9/11 20:12, YueHaibing wrote:
>> >> Fixes gcc '-Wunused-but-set-variable' warning:
>> >>
>> >> drivers/net/wireless/realtek/rtlwifi/base.c: In function
>> 'rtl_c2h_content_parsing':
>> >> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
>> >>  variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
>> >>
>> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Thanks for your fix.
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

For some reason I couldn't find the original patch from patchwork.
I didn't find the version sent today though:

https://patchwork.kernel.org/patch/10787619/

BTW YueHaibing, you can check the linux-wireless patch status yourself from
the patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork

-- 
Kalle Valo

Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'

[YueHaibing]

On 2019/1/30 18:47, Kalle Valo wrote:
> Pkshih <pkshih@realtek.com> writes:
> 
>> On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote:
>>> +cc netdev@vger.kernel.org
>>>
>>> On 2019/1/29 13:57, YueHaibing wrote:
>>>> ping...
>>>>  
>>>> On 2018/9/11 20:12, YueHaibing wrote:
>>>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>>>
>>>>> drivers/net/wireless/realtek/rtlwifi/base.c: In function
>>> 'rtl_c2h_content_parsing':
>>>>> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
>>>>>   variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
>>>>>
>>>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> Thanks for your fix.
>>
>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> For some reason I couldn't find the original patch from patchwork.
> I didn't find the version sent today though:
> 
> https://patchwork.kernel.org/patch/10787619/
> 
> BTW YueHaibing, you can check the linux-wireless patch status yourself from
> the patchwork:

Thanks, I'll check it.


> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork
>