From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8689AC282D7 for ; Wed, 30 Jan 2019 23:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4AB3F21473 for ; Wed, 30 Jan 2019 23:50:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727654AbfA3Xut convert rfc822-to-8bit (ORCPT ); Wed, 30 Jan 2019 18:50:49 -0500 Received: from smtp-prod03.osg.ufl.edu ([128.227.74.219]:35164 "EHLO smtp.ufl.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725811AbfA3Xus (ORCPT ); Wed, 30 Jan 2019 18:50:48 -0500 X-UFL-GatorLink-Authenticated: authenticated as () with from 10.36.197.37 Received: from exmbxprd16.ad.ufl.edu ([10.36.197.37]) by smtp.ufl.edu (8.14.4/8.14.4/3.0.0) with ESMTP id x0UNojqp013617 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Wed, 30 Jan 2019 18:50:45 -0500 Received: from exmbxprd18.ad.ufl.edu (10.36.197.39) by exmbxprd16.ad.ufl.edu (10.36.197.37) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 30 Jan 2019 18:50:44 -0500 Received: from exmbxprd18.ad.ufl.edu ([fe80::890c:cba5:27b2:db27]) by exmbxprd18.ad.ufl.edu ([fe80::890c:cba5:27b2:db27%19]) with mapi id 15.00.1395.000; Wed, 30 Jan 2019 18:50:44 -0500 From: "Yavuz, Tuba" To: David Miller CC: "netdev@vger.kernel.org" Subject: Re: [PATCH] : net : hso : do not call unregister_netdev if not registered Thread-Topic: [PATCH] : net : hso : do not call unregister_netdev if not registered Thread-Index: AQHUtyaF1PIYk7B+iEeOkw3AvuTpbKXIs0OA///Lm1A= Date: Wed, 30 Jan 2019 23:50:44 +0000 Message-ID: <1548892244654.57194@ece.ufl.edu> References: <1548692918696.27977@ece.ufl.edu>,<20190130.135803.1455746285854639679.davem@davemloft.net> In-Reply-To: <20190130.135803.1455746285854639679.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.36.134.12] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-30_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901300169 X-UFL-Spam-Level: * Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi David, I'll fix the spaces in the subject. When I checked my patch it only had a p0 patch warning but I am not sure how to fix it. WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch total: 0 errors, 1 warnings, 0 checks, 8 lines checked drivers/net/usb/hso.patch has style problems, please review. So, please advise. Best, Tuba Yavuz, Ph.D. Assistant Professor Electrical and Computer Engineering Department University of Florida Gainesville, FL 32611 Webpage: http://www.tuba.ece.ufl.edu/ Email: tuba@ece.ufl.edu Phone: (352) 846 0202 ________________________________________ From: David Miller Sent: Wednesday, January 30, 2019 4:58 PM To: Yavuz, Tuba Cc: netdev@vger.kernel.org Subject: Re: [PATCH] : net : hso : do not call unregister_netdev if not registered From: "Yavuz, Tuba" Date: Mon, 28 Jan 2019 16:28:38 +0000 > On an error path inside the hso_create_net_device function of the hso > driver, hso_free_net_device gets called. This causes potentially a > negative reference count in the net device if register_netdev has not > been called yet as hso_free_net_device calls unregister_netdev > regardless. I think the driver should distinguish these cases and call > unregister_netdev only if register_netdev has been called. > > Reported-by: Tuba Yavuz > Signed-off-by: Tuba Yavuz This does not apply cleanly to the net tree. Also, please stop putting those spaces after the subsystem prefixes in your Subject line. Put the colon character immediately after each subsystem prefix. Thank you.