From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A647EC282CC for ; Wed, 6 Feb 2019 00:38:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CAAF2183E for ; Wed, 6 Feb 2019 00:38:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727752AbfBFAig convert rfc822-to-8bit (ORCPT ); Tue, 5 Feb 2019 19:38:36 -0500 Received: from smtp-prod04.osg.ufl.edu ([128.227.74.220]:47424 "EHLO smtp.ufl.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727591AbfBFAig (ORCPT ); Tue, 5 Feb 2019 19:38:36 -0500 X-UFL-GatorLink-Authenticated: authenticated as () with from 10.36.197.37 Received: from exmbxprd16.ad.ufl.edu ([10.36.197.37]) by smtp.ufl.edu (8.14.4/8.14.4/3.0.0) with ESMTP id x160cWBr005681 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Tue, 5 Feb 2019 19:38:32 -0500 Received: from exmbxprd18.ad.ufl.edu (10.36.197.39) by exmbxprd16.ad.ufl.edu (10.36.197.37) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 5 Feb 2019 19:38:31 -0500 Received: from exmbxprd18.ad.ufl.edu ([fe80::890c:cba5:27b2:db27]) by exmbxprd18.ad.ufl.edu ([fe80::890c:cba5:27b2:db27%19]) with mapi id 15.00.1395.000; Tue, 5 Feb 2019 19:38:31 -0500 From: "Yavuz, Tuba" To: David Miller CC: "netdev@vger.kernel.org" Subject: Re: [PATCH]: net: hso: do not call unregister if not registered Thread-Topic: [PATCH]: net: hso: do not call unregister if not registered Thread-Index: AQHUvaazReHuqgMz1EmuNaBJPDdg0KXSQJEA//+sVlA= Date: Wed, 6 Feb 2019 00:38:31 +0000 Message-ID: <1549413511445.2427@ece.ufl.edu> References: <1549407687058.71019@ece.ufl.edu>,<20190205.163640.175589510190486514.davem@davemloft.net> In-Reply-To: <20190205.163640.175589510190486514.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.36.198.15] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-05_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902060002 X-UFL-Spam-Level: * Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is surprising as I got total: 0 errors, 0 warnings, 0 checks, 10 lines checked. Anyhow, I'll submit as suggested. Best, Tuba Yavuz, Ph.D. Assistant Professor Electrical and Computer Engineering Department University of Florida Gainesville, FL 32611 Webpage: http://www.tuba.ece.ufl.edu/ Email: tuba@ece.ufl.edu Phone: (352) 846 0202 ________________________________________ From: David Miller Sent: Tuesday, February 5, 2019 7:36 PM To: Yavuz, Tuba Cc: netdev@vger.kernel.org Subject: Re: [PATCH]: net: hso: do not call unregister if not registered From: "Yavuz, Tuba" Date: Tue, 5 Feb 2019 23:01:25 +0000 > > > On an error path inside the hso_create_net_device function of the hso > driver, hso_free_net_device gets called. This causes potentially a > negative reference count in the net device if register_netdev has not > been called yet as hso_free_net_device calls unregister_netdev > regardless. I think the driver should distinguish these cases and call > unregister_netdev only if register_netdev has been called. > > Signed-off-by: Tuba Yavuz > --- > > --- linux-stable/drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500 > +++ linux-stable/drivers/net/usb/hso.c 2019-02-05 17:54:17.056496019 -0500 > @@ -2377,7 +2377,9 @@ static void hso_free_net_device(struct h > > remove_net_device(hso_net->parent); > > - if (hso_net->net) > + if (hso_net->net && > + hso_net->net->reg_state == NETREG_REGISTERED > + ) This is not formatted correctly, the final closing ')' should end the previous line, like this: if (hso_net->net && hso_net->net->reg_state == NETREG_REGISTERED)