From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D255FC169C4 for ; Sat, 9 Feb 2019 00:03:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6DDD2177B for ; Sat, 9 Feb 2019 00:03:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726704AbfBIADB convert rfc822-to-8bit (ORCPT ); Fri, 8 Feb 2019 19:03:01 -0500 Received: from smtp-prod03.osg.ufl.edu ([128.227.74.219]:57526 "EHLO smtp.ufl.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726655AbfBIADB (ORCPT ); Fri, 8 Feb 2019 19:03:01 -0500 X-UFL-GatorLink-Authenticated: authenticated as () with from 10.36.197.40 Received: from exmbxprd19.ad.ufl.edu ([10.36.197.40]) by smtp.ufl.edu (8.14.4/8.14.4/3.0.0) with ESMTP id x1902v49026775 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 8 Feb 2019 19:02:58 -0500 Received: from exmbxprd18.ad.ufl.edu (10.36.197.39) by exmbxprd19.ad.ufl.edu (10.36.197.40) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 8 Feb 2019 19:02:57 -0500 Received: from exmbxprd18.ad.ufl.edu ([fe80::890c:cba5:27b2:db27]) by exmbxprd18.ad.ufl.edu ([fe80::890c:cba5:27b2:db27%19]) with mapi id 15.00.1395.000; Fri, 8 Feb 2019 19:02:57 -0500 From: "Yavuz, Tuba" To: David Miller CC: "netdev@vger.kernel.org" Subject: Re: [PATCH] net: hso: do not unregister if not registered Thread-Topic: [PATCH] net: hso: do not unregister if not registered Thread-Index: AQHUvbRUxirTwLQbDk6sRs+YSfWrnqXW3sMA//+7QIw= Date: Sat, 9 Feb 2019 00:02:56 +0000 Message-ID: <1549670577031.62975@ece.ufl.edu> References: <1549413631237.66546@ece.ufl.edu>,<20190208.150818.2115309831038338250.davem@davemloft.net> In-Reply-To: <20190208.150818.2115309831038338250.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.36.198.11] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-08_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=871 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902080160 X-UFL-Spam-Level: * Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I just resubmitted the patch and made sure to send it in plaintext. Hopefully, it will work this time. Best, Tuba ________________________________________ From: David Miller Sent: Friday, February 8, 2019 6:08 PM To: Yavuz, Tuba Cc: netdev@vger.kernel.org Subject: Re: [PATCH] net: hso: do not unregister if not registered From: "Yavuz, Tuba" Date: Wed, 6 Feb 2019 00:40:31 +0000 > > On an error path inside the hso_create_net_device function of the hso > driver, hso_free_net_device gets called. This causes potentially a > negative reference count in the net device if register_netdev has not > been called yet as hso_free_net_device calls unregister_netdev > regardless. I think the driver should distinguish these cases and call > unregister_netdev only if register_netdev has been called. > > Signed-off-by: Tuba Yavuz This patch is corrupted by your email client.