From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15CDCC282C4 for ; Tue, 12 Feb 2019 15:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5AB521773 for ; Tue, 12 Feb 2019 15:47:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="MEeiVvkE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730727AbfBLPro (ORCPT ); Tue, 12 Feb 2019 10:47:44 -0500 Received: from m12-13.163.com ([220.181.12.13]:34418 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbfBLPrn (ORCPT ); Tue, 12 Feb 2019 10:47:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=SDwy9VEyvCqvxmsmPK V6JS7l4q5ZRpYsHOI5oSSbPHc=; b=MEeiVvkEESyYrBC5lbjDosVJaWYF7zdHff LAMUAlDEJDw/EXyEqHC6EyD6AP4pDm4C3yj/HqVkgPgKDx+OZtpp+jFfDtPKjcZz xF4OaGu//+Vovc0pLmSShhkOTvHWV7VQTJ7TsGSkaf+FNmfIZeNJP3A+Yp3JUbFa apo7NBjTE= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp9 (Coremail) with SMTP id DcCowAA3OJeV6mJcRQ_CEw--.58501S3; Tue, 12 Feb 2019 23:47:34 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: jdmason@kudzu.us, davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: neterion: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Tue, 12 Feb 2019 23:47:31 +0800 Message-Id: <1549986451-4780-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DcCowAA3OJeV6mJcRQ_CEw--.58501S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrWDur17tr48tF17Kr15Arb_yoW8Gw17pF WDA347uryktFy5Za1kJ3Z7Zr98Xayxtr98WFZ3Z3yFvF95Jry5AF15GrWYvw4YqrWkCF1a vr4Fv34SyF98WwUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UVyIbUUUUU= X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiwANZolXli04UTwABsX Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/neterion/s2io.c | 2 +- drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index 82be900..feda964 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c @@ -3055,7 +3055,7 @@ static void tx_intr_handler(struct fifo_info *fifo_data) /* Updating the statistics block */ swstats->mem_freed += skb->truesize; - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); get_info.offset++; if (get_info.offset == get_info.fifo_len + 1) diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c index 5ae3fa8..76410ae 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c @@ -114,7 +114,7 @@ static inline void VXGE_COMPLETE_VPATH_TX(struct vxge_fifo *fifo) /* free SKBs */ for (temp = completed; temp != skb_ptr; temp++) - dev_kfree_skb_irq(*temp); + dev_consume_skb_irq(*temp); } while (more); } -- 2.7.4