From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D739C282C4 for ; Tue, 12 Feb 2019 15:55:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD84620842 for ; Tue, 12 Feb 2019 15:55:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="W5gzwDmb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730735AbfBLPzX (ORCPT ); Tue, 12 Feb 2019 10:55:23 -0500 Received: from m12-12.163.com ([220.181.12.12]:33063 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728347AbfBLPzX (ORCPT ); Tue, 12 Feb 2019 10:55:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=KOYZs9fy39quiPEzoQ 2vd43MV58kd4tvSl+Sy4J4jT4=; b=W5gzwDmb1V41KQg1K/lJ9uM9Wti3AjZzC/ eHlKwCVJ99ejKQLmV0oOpODNaJL/Ie8ZTTUR5XNBKDMjBovKhqDdByLElpKtRYv0 MGDm0kILekmom2AQ6zlD1XojX6Eficpgpz2+EapZKhQbmsgHi32+oxvDZBBtAkbt Pi5PiAUHI= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp8 (Coremail) with SMTP id DMCowACHHM4m62JcAULaFA--.35064S3; Tue, 12 Feb 2019 23:50:00 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: timur@kernel.org, davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: qualcomm: emac: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Tue, 12 Feb 2019 23:49:57 +0800 Message-Id: <1549986597-4837-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DMCowACHHM4m62JcAULaFA--.35064S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF13WFWkGrW5Wr4Durg_yoWfCFg_Ww 1Sq3WxXw4UCF4akwn2kan0v34F9w1DZr4kC34xKa98A34DCFn5u398JrZxWr13G3y8JF17 KF12qFZ3CayjqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUj-eOtUUUUU== X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiLx5ZolUMKoPtQgAAsV Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in emac_mac_tx_process() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/qualcomm/emac/emac-mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/emac/emac-mac.c b/drivers/net/ethernet/qualcomm/emac/emac-mac.c index 8d79031..20d2400 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac-mac.c +++ b/drivers/net/ethernet/qualcomm/emac/emac-mac.c @@ -1204,7 +1204,7 @@ void emac_mac_tx_process(struct emac_adapter *adpt, struct emac_tx_queue *tx_q) if (tpbuf->skb) { pkts_compl++; bytes_compl += tpbuf->skb->len; - dev_kfree_skb_irq(tpbuf->skb); + dev_consume_skb_irq(tpbuf->skb); tpbuf->skb = NULL; } -- 2.7.4