From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E923C282C4 for ; Tue, 12 Feb 2019 16:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2AA22184E for ; Tue, 12 Feb 2019 16:17:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="knsHDx4D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730976AbfBLQR6 (ORCPT ); Tue, 12 Feb 2019 11:17:58 -0500 Received: from m12-11.163.com ([220.181.12.11]:58668 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729355AbfBLQR6 (ORCPT ); Tue, 12 Feb 2019 11:17:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=ktpULuVfGJNiE9DWvx JgGKzQb8tjgfkIK1qyFioUnpQ=; b=knsHDx4DF3LAvhYX4+siBpDtOtXO11yIf3 gmU6NsgaApnoqgA8Z3WxAzivfJphpNekfnUEx++jihX16KVi9PUs/Olb6YNA6Uq2 UGpaPQNDT9n+s0b3nYFEnLeEPblAyqErrXbG9x0OhiLeRUPDnV56WuR1awavZjT9 ks+OH6zh0= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp7 (Coremail) with SMTP id C8CowACn15PK7GJccnu3FA--.54965S3; Tue, 12 Feb 2019 23:57:00 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: fealnx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Tue, 12 Feb 2019 23:56:53 +0800 Message-Id: <1549987013-5096-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: C8CowACn15PK7GJccnu3FA--.54965S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF48tw48tF4DWFWxZwb_yoWftrc_uw 12vryxJw45C345Kw1DKF1Fya4Y9w4DXr4S9FyIgayfta4qy3s8JrWrXr1kGFnxWa1UAr13 Kr9IqFW8A3y7tjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjxpntUUUUU== X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiLw9ZolUMKoQfUwAAsg Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in intr_handler() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/fealnx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c index ae55da6..c24fd56 100644 --- a/drivers/net/ethernet/fealnx.c +++ b/drivers/net/ethernet/fealnx.c @@ -1531,7 +1531,7 @@ static irqreturn_t intr_handler(int irq, void *dev_instance) /* Free the original skb. */ pci_unmap_single(np->pci_dev, np->cur_tx->buffer, np->cur_tx->skbuff->len, PCI_DMA_TODEVICE); - dev_kfree_skb_irq(np->cur_tx->skbuff); + dev_consume_skb_irq(np->cur_tx->skbuff); np->cur_tx->skbuff = NULL; --np->really_tx_count; if (np->cur_tx->control & TXLD) { -- 2.7.4