From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 691ECC282C4 for ; Tue, 12 Feb 2019 15:59:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 332F3217D9 for ; Tue, 12 Feb 2019 15:59:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="IaocEVo0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730744AbfBLP7Y (ORCPT ); Tue, 12 Feb 2019 10:59:24 -0500 Received: from m12-12.163.com ([220.181.12.12]:55686 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730006AbfBLP7X (ORCPT ); Tue, 12 Feb 2019 10:59:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=OFXhAyOOmUcU1bLjc+ uqmpAy7VUHNsX5zQYOafnoXPM=; b=IaocEVo0cHztNC4IJNKZ3rOS/15DMTp99J OpDfxdlYlFG9Cq9Dc2SjuTm36Pzn2NXcM+mgwO3phItMOxL2HaK5Pgsp2KurAz3I 2jTiLI0Ob9ff3aJmnW8Zdfw8a1PqO/QvIK/mwPs/pVvx2b9PZuRzkjxqEsB+YMAy odKvPbVtw= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp8 (Coremail) with SMTP id DMCowAC3+cNJ7WJcRzzcFA--.25863S3; Tue, 12 Feb 2019 23:59:06 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: romieu@fr.zoreil.com, davem@davemloft.net, venza@brownhat.org, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: sis: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Tue, 12 Feb 2019 23:59:04 +0800 Message-Id: <1549987144-5333-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DMCowAC3+cNJ7WJcRzzcFA--.25863S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrWDur17Ww45Zw4UAr18Xwb_yoW8Gw47pF WUA3yUCwn7JF1UXan5Ga1vqFW5Xay8tryxWFWfCw1rZr93AF4YqF1DKFWjvr4jyrWkGF17 t34jvws3tFn8ZwUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U6Wl9UUUUU= X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiHQVZolSIdHcQVwAAs7 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/sis/sis190.c | 2 +- drivers/net/ethernet/sis/sis900.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sis/sis190.c b/drivers/net/ethernet/sis/sis190.c index 808cf98..5b351be 100644 --- a/drivers/net/ethernet/sis/sis190.c +++ b/drivers/net/ethernet/sis/sis190.c @@ -714,7 +714,7 @@ static void sis190_tx_interrupt(struct net_device *dev, sis190_unmap_tx_skb(tp->pci_dev, skb, txd); tp->Tx_skbuff[entry] = NULL; - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); } if (tp->dirty_tx != dirty_tx) { diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index 4bb89f7..6073387 100644 --- a/drivers/net/ethernet/sis/sis900.c +++ b/drivers/net/ethernet/sis/sis900.c @@ -1927,7 +1927,7 @@ static void sis900_finish_xmit (struct net_device *net_dev) pci_unmap_single(sis_priv->pci_dev, sis_priv->tx_ring[entry].bufptr, skb->len, PCI_DMA_TODEVICE); - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); sis_priv->tx_skbuff[entry] = NULL; sis_priv->tx_ring[entry].bufptr = 0; sis_priv->tx_ring[entry].cmdsts = 0; -- 2.7.4