From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640AEC282C4 for ; Tue, 12 Feb 2019 16:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19726217FA for ; Tue, 12 Feb 2019 16:00:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="YFXLYB9B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730754AbfBLQAZ (ORCPT ); Tue, 12 Feb 2019 11:00:25 -0500 Received: from m12-15.163.com ([220.181.12.15]:59410 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728347AbfBLQAY (ORCPT ); Tue, 12 Feb 2019 11:00:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=dsV17FMJ/oDH3rmfjp G6oAU0r333lYovGKUkXms9Nt8=; b=YFXLYB9BR4XamG9GUCK/IICvgwOEnw7y8W cin/L0oMiXeO13gTUXYfJh4ZFhi4wGgV7NHUAqo9oMo4LqGQ2XgjX8LdeFSBIVpW FilcJKZ4wLWNFArSZRK0Puzt4oXkONQu87uNT+E4md4n6y/upWIY0SVS5FKoJ9/a ifYehkYns= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp11 (Coremail) with SMTP id D8CowADn91OD7WJcUBZZCw--.5461S3; Wed, 13 Feb 2019 00:00:04 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: nicolas.ferre@microchip.com, davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: macb: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Wed, 13 Feb 2019 00:00:02 +0800 Message-Id: <1549987202-5393-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: D8CowADn91OD7WJcUBZZCw--.5461S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF1kWF4Dur13WF4xXrb_yoWfCrc_Gw 12vrySqa1UXrnFkw4FvF4Yv34FvryDXrs3Cwn2kFWYyasrXw1DAa15Zr93Gr1fWw1xGFnr GF9Fqayq9347XjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjItCDUUUUU== X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiHRJZolSIdHcR9AAAsO Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in at91ether_interrupt() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 2b28826..835cc58 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -3763,7 +3763,7 @@ static irqreturn_t at91ether_interrupt(int irq, void *dev_id) dev->stats.tx_errors++; if (lp->skb) { - dev_kfree_skb_irq(lp->skb); + dev_consume_skb_irq(lp->skb); lp->skb = NULL; dma_unmap_single(NULL, lp->skb_physaddr, lp->skb_length, DMA_TO_DEVICE); -- 2.7.4