From: David Ahern <dsahern@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, andrew+netdev@lunn.ch, petrm@nvidia.com,
lirongqing@baidu.com
Subject: Re: [PATCH net-next 1/3] vrf: Remove unnecessary NULL check
Date: Tue, 24 Mar 2026 13:06:23 -0600 [thread overview]
Message-ID: <154d612f-2621-488c-9c9e-984062345ea9@kernel.org> (raw)
In-Reply-To: <20260324155521.525292-2-idosch@nvidia.com>
On 3/24/26 9:55 AM, Ido Schimmel wrote:
> The VRF driver always allocates an IPv4 dst entry for a VRF device and
> prevents the device from being registered if the allocation fails.
>
> Therefore, there is no need to check if the entry exists when tearing
> down a VRF device. Remove the check.
>
> Note that the same is not true for the IPv6 dst entry. Its creation can
> be skipped if IPv6 is administratively disabled (i.e.,
> 'ipv6.disable=1').
>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> drivers/net/vrf.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2026-03-24 19:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 15:55 [PATCH net-next 0/3] vrf: A few cleanups Ido Schimmel
2026-03-24 15:55 ` [PATCH net-next 1/3] vrf: Remove unnecessary NULL check Ido Schimmel
2026-03-24 19:06 ` David Ahern [this message]
2026-03-24 15:55 ` [PATCH net-next 2/3] vrf: Use dst_dev_put() instead of using loopback device Ido Schimmel
2026-03-24 19:07 ` David Ahern
2026-03-24 15:55 ` [PATCH net-next 3/3] vrf: Remove unnecessary synchronize_rcu() invocations Ido Schimmel
2026-03-24 19:09 ` David Ahern
2026-03-24 20:39 ` Eric Dumazet
2026-03-25 14:17 ` David Ahern
2026-03-25 14:42 ` Ido Schimmel
2026-03-25 14:57 ` Eric Dumazet
2026-03-25 20:11 ` Ido Schimmel
2026-03-25 22:35 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154d612f-2621-488c-9c9e-984062345ea9@kernel.org \
--to=dsahern@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox