From: Hannes Eder <hannes@hanneseder.net>
To: Karsten Keil <kkeil@suse.de>
Cc: Daniele Venzano <venza@brownhat.org>,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] Fix missing ifdef in isdn_ppp
Date: Fri, 23 Jan 2009 10:44:11 +0100 [thread overview]
Message-ID: <154e089b0901230144o2b52c232kb93a71429fb258a9@mail.gmail.com> (raw)
In-Reply-To: <20090122221827.GA28623@pingi.kke.suse.de>
Add CC. I think this could go upstream via David Miller's net-2.6 tree.
Best,
Hannes
On Thu, Jan 22, 2009 at 11:18 PM, Karsten Keil <kkeil@suse.de> wrote:
> The following patch fixes a warning caused by a missing ifdef in
> isdn_ppp.c. A function was defined, but never used if CONFIG_IPPP_FILTER
> was not defined.
>
> The warning was: 'get_filter' defined but not used
> Patch is against 2.6.28.1
>
> Signed-off-by: Daniele Venzano <venza@brownhat.org>
> Acked-by: Karsten Keil <kkeil@suse.de>
>
> --- a/drivers/isdn/i4l/isdn_ppp.c 2009-01-22 15:01:27.000000000 +0100
> +++ b/drivers/isdn/i4l/isdn_ppp.c 2009-01-22 15:01:59.000000000 +0100
> @@ -431,6 +431,7 @@ set_arg(void __user *b, void *val,int le
> return 0;
> }
>
> +#ifdef CONFIG_IPPP_FILTER
> static int get_filter(void __user *arg, struct sock_filter **p)
> {
> struct sock_fprog uprog;
> @@ -465,6 +466,7 @@ static int get_filter(void __user *arg,
> *p = code;
> return uprog.len;
> }
> +#endif /* CONFIG_IPPP_FILTER */
>
> /*
> * ippp device ioctl
>
next parent reply other threads:[~2009-01-23 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090122221827.GA28623@pingi.kke.suse.de>
2009-01-23 9:44 ` Hannes Eder [this message]
2009-01-26 20:24 ` [PATCH] Fix missing ifdef in isdn_ppp David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154e089b0901230144o2b52c232kb93a71429fb258a9@mail.gmail.com \
--to=hannes@hanneseder.net \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=venza@brownhat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).