From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, lkp@intel.com
Subject: Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate
Date: Thu, 04 Jan 2018 15:43:28 -0700 [thread overview]
Message-ID: <154e3adaf0825906fa3240f3b15247eb@codeaurora.org> (raw)
In-Reply-To: <1515051890.131759.6.camel@gmail.com>
>> The real device over which the rmnet devices are installed also
>> aggregate multiple IP packets and sends them as a single large
>> aggregate
>> frame to the hardware.
>
> It would be nice to give some details about this in the changelog.
>
> Also what results you get with different values for the shift (10, 9,
> 8)
>
> My fear is that people might be tempted to blindly use the
> sk_pacing_shift_update() just because a single TCP flow gets 'better'
> results.
>
> bufferbloat is a serious issue, we do not want to allow a single TCP
> flow to fill a fifo.
>
> Otherwise, we could remove TCP Small queues overhead from the kernel
> and be happy.
>
> Thanks.
The test was run with iperf single stream TCP TX for a duration of 30s.
Pacing shift | Observed data rate (Mbps)
10 | 9
9 | 140
8 | 146
I will update all of this in the commit text in v3.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-01-04 22:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 21:42 [PATCH net-next v2 00/10] net: qualcomm: rmnet: Enable csum offloads Subash Abhinov Kasiviswanathan
2018-01-03 21:42 ` [PATCH net-next v2 01/10] net: qualcomm: rmnet: Remove redundant check when stamping map header Subash Abhinov Kasiviswanathan
2018-01-03 21:42 ` [PATCH net-next v2 02/10] net: qualcomm: rmnet: Remove invalid condition while stamping mux id Subash Abhinov Kasiviswanathan
2018-01-03 21:43 ` [PATCH net-next v2 03/10] net: qualcomm: rmnet: Remove unused function declaration Subash Abhinov Kasiviswanathan
2018-01-03 21:43 ` [PATCH net-next v2 04/10] net: qualcomm: rmnet: Rename ingress data format to data format Subash Abhinov Kasiviswanathan
2018-01-03 21:43 ` [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate Subash Abhinov Kasiviswanathan
2018-01-03 22:01 ` Eric Dumazet
2018-01-03 22:45 ` Subash Abhinov Kasiviswanathan
2018-01-04 7:44 ` Eric Dumazet
2018-01-04 22:43 ` Subash Abhinov Kasiviswanathan [this message]
2018-01-03 21:43 ` [PATCH net-next v2 06/10] net: qualcomm: rmnet: Define the MAPv4 packet formats Subash Abhinov Kasiviswanathan
2018-01-03 21:43 ` [PATCH net-next v2 07/10] net: qualcomm: rmnet: Add support for RX checksum offload Subash Abhinov Kasiviswanathan
2018-01-03 21:43 ` [PATCH net-next v2 08/10] net: qualcomm: rmnet: Handle command packets with checksum trailer Subash Abhinov Kasiviswanathan
2018-01-03 21:43 ` [PATCH net-next v2 09/10] net: qualcomm: rmnet: Add support for TX checksum offload Subash Abhinov Kasiviswanathan
2018-01-03 21:43 ` [PATCH net-next v2 10/10] net: qualcomm: rmnet: Add support for GSO Subash Abhinov Kasiviswanathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154e3adaf0825906fa3240f3b15247eb@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).