From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 811D7C282C2 for ; Wed, 13 Feb 2019 15:15:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 453B8222B1 for ; Wed, 13 Feb 2019 15:15:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="iSr+mlLZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730964AbfBMPPH (ORCPT ); Wed, 13 Feb 2019 10:15:07 -0500 Received: from m12-14.163.com ([220.181.12.14]:54841 "EHLO m12-14.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729139AbfBMPPG (ORCPT ); Wed, 13 Feb 2019 10:15:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=E9aFf5LtpbJCEpzXhS VBA6Yg3Jv7RugtwHLSl3cNypU=; b=iSr+mlLZRhj6dJlIwLjMUs/Nbx3Y6MuweC kdzqQW+0Fg0X1kFqWsFae4IdjRhLkIV6p+mxFmOyvdZJnn+8U3cvZfsIqbCVlVlo y5fiKeTbbr+QWwHmO3P2deQHXXnCcFSYO+hqi2dP7Ldi2Q7/x68i2RQxGul0KIqj p2Gc3zqQA= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp10 (Coremail) with SMTP id DsCowAB3aRRyNGRcPXUAFg--.34487S3; Wed, 13 Feb 2019 23:14:59 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: amd: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Wed, 13 Feb 2019 23:14:54 +0800 Message-Id: <1550070894-4602-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DsCowAB3aRRyNGRcPXUAFg--.34487S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrWDur17WFykKFWDurW3ZFb_yoW8GFW3pa yUCas7urn7JF15ZaykJa1kXFs8Xa13tryFgF13Ca9Y9rn0y3yUtF1kGFy2krs8JF48GF1a vr4Fva4I9FnYq37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UsqXLUUUUU= X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/xtbBERNaolaD2h14SgAAsa Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/amd/lance.c | 2 +- drivers/net/ethernet/amd/ni65.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c index b56d84c..f90b454 100644 --- a/drivers/net/ethernet/amd/lance.c +++ b/drivers/net/ethernet/amd/lance.c @@ -1084,7 +1084,7 @@ static irqreturn_t lance_interrupt(int irq, void *dev_id) /* We must free the original skb if it's not a data-only copy in the bounce buffer. */ if (lp->tx_skbuff[entry]) { - dev_kfree_skb_irq(lp->tx_skbuff[entry]); + dev_consume_skb_irq(lp->tx_skbuff[entry]); lp->tx_skbuff[entry] = NULL; } dirty_tx++; diff --git a/drivers/net/ethernet/amd/ni65.c b/drivers/net/ethernet/amd/ni65.c index 8931ce6..87ff5d6 100644 --- a/drivers/net/ethernet/amd/ni65.c +++ b/drivers/net/ethernet/amd/ni65.c @@ -1028,7 +1028,7 @@ static void ni65_xmit_intr(struct net_device *dev,int csr0) #ifdef XMT_VIA_SKB if(p->tmd_skb[p->tmdlast]) { - dev_kfree_skb_irq(p->tmd_skb[p->tmdlast]); + dev_consume_skb_irq(p->tmd_skb[p->tmdlast]); p->tmd_skb[p->tmdlast] = NULL; } #endif -- 2.7.4