From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A393C282CA for ; Wed, 13 Feb 2019 15:17:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DDE6222CC for ; Wed, 13 Feb 2019 15:17:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="VyjxGfms" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391592AbfBMPRZ (ORCPT ); Wed, 13 Feb 2019 10:17:25 -0500 Received: from m12-13.163.com ([220.181.12.13]:34676 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389892AbfBMPRZ (ORCPT ); Wed, 13 Feb 2019 10:17:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=MQptTj4DbtFQzVbggo UroEWgfm+ug76021crtLajqDI=; b=VyjxGfmsNEdL+ZbIQF984wgxX4rgGbsiyF DXlGFdQh/VAsmolgDxd4wgBV7F7w3aMcnEIhx5IbJcIt6KSL/8lXHxN9g1gsIxO7 mJbs0XEV2l5O3RwdiE5PPPpWzzIvFr4Oi8SU/wXQqAbc4fT9NdM0bbAdW2j06QKe BNgJOSm8c= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp9 (Coremail) with SMTP id DcCowACXMHz2NGRcsJ+qFA--.3144S3; Wed, 13 Feb 2019 23:17:11 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: ralf@linux-mips.org, davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: sgi: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Wed, 13 Feb 2019 23:17:06 +0800 Message-Id: <1550071026-4723-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DcCowACXMHz2NGRcsJ+qFA--.3144S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrWDZw4DGr1fAw13Kr17Wrg_yoW8Xr1xpa y5Aay09rZ7Jw1aqas5Ja18ZFyrXay7KryrWFyFv3yrXrnxAF13Jry8KFyYvr42vrWkXF13 tr15Z3s2kFs8ZrUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UIQ6XUUUUU= X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiLxdaolUMKpDB5QAAsH Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/sgi/ioc3-eth.c | 2 +- drivers/net/ethernet/sgi/meth.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index 3140999..358e66b 100644 --- a/drivers/net/ethernet/sgi/ioc3-eth.c +++ b/drivers/net/ethernet/sgi/ioc3-eth.c @@ -666,7 +666,7 @@ static inline void ioc3_tx(struct net_device *dev) packets++; skb = ip->tx_skbs[o_entry]; bytes += skb->len; - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); ip->tx_skbs[o_entry] = NULL; o_entry = (o_entry + 1) & 127; /* Next */ diff --git a/drivers/net/ethernet/sgi/meth.c b/drivers/net/ethernet/sgi/meth.c index 0e1b7e9..a80971d 100644 --- a/drivers/net/ethernet/sgi/meth.c +++ b/drivers/net/ethernet/sgi/meth.c @@ -521,7 +521,7 @@ static void meth_tx_cleanup(struct net_device* dev, unsigned long int_status) DPRINTK("RPTR points us here, but packet not done?\n"); break; } - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); priv->tx_skbs[priv->tx_read] = NULL; priv->tx_ring[priv->tx_read].header.raw = 0; priv->tx_read = (priv->tx_read+1)&(TX_RING_ENTRIES-1); -- 2.7.4