From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ACACC282C2 for ; Wed, 13 Feb 2019 15:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6376C222CA for ; Wed, 13 Feb 2019 15:18:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="P+DFyX7+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391623AbfBMPSS (ORCPT ); Wed, 13 Feb 2019 10:18:18 -0500 Received: from m12-12.163.com ([220.181.12.12]:47612 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730964AbfBMPSS (ORCPT ); Wed, 13 Feb 2019 10:18:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=d7L1P3Zmep3U+e0xL8 trqPxix3ASE6ZzyeTY5o9ZsDw=; b=P+DFyX7+1yceZG0CiSdlFPEAr4GarsoqHf LzAP4klqfdvmtyLlyaW6Td0Y2i5yG5qEvPAmDDItRMqcNuxtmPgIKjvd4t0DEcYN r8mi8EgKalIUQObbkt0ik6p33Yu5Sp/CsY1mXyrXbpHbU0A45Qd/6jUoBXNM4OK7 SEXdviztY= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp8 (Coremail) with SMTP id DMCowABnroIzNWRchJbCFQ--.55857S3; Wed, 13 Feb 2019 23:18:12 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: micrel: ks8695net: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Wed, 13 Feb 2019 23:18:09 +0800 Message-Id: <1550071089-4776-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DMCowABnroIzNWRchJbCFQ--.55857S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF48tw48tw13Zr1fWFg_yoWfurb_uw 1v9wsxJ3y3JrWag3W8Kr4rCFWFkwn8XrWfuFW0gFWfJa42kwn5CrW8GFyDW3WrGrs7GFn3 XrZIq3yrA347XjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjI387UUUUU== X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiERRaolWBkKV0sAAAsY Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in ks8695_tx_irq() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/micrel/ks8695net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/micrel/ks8695net.c b/drivers/net/ethernet/micrel/ks8695net.c index b881f5d..6006d47 100644 --- a/drivers/net/ethernet/micrel/ks8695net.c +++ b/drivers/net/ethernet/micrel/ks8695net.c @@ -391,7 +391,7 @@ ks8695_tx_irq(int irq, void *dev_id) ksp->tx_buffers[buff_n].dma_ptr, ksp->tx_buffers[buff_n].length, DMA_TO_DEVICE); - dev_kfree_skb_irq(ksp->tx_buffers[buff_n].skb); + dev_consume_skb_irq(ksp->tx_buffers[buff_n].skb); ksp->tx_buffers[buff_n].skb = NULL; ksp->tx_ring_used--; } -- 2.7.4