From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15651C43381 for ; Thu, 14 Feb 2019 14:45:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D235222D9 for ; Thu, 14 Feb 2019 14:45:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="hFiDeZVU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390743AbfBNOpt (ORCPT ); Thu, 14 Feb 2019 09:45:49 -0500 Received: from m12-15.163.com ([220.181.12.15]:59677 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733099AbfBNOpt (ORCPT ); Thu, 14 Feb 2019 09:45:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=c9kRmUFJjmrSGpMII/ GJCxz1oCnxP5jR9I1asIVHziM=; b=hFiDeZVUUea7uN9RIH5g5zNHMI/bRWqQrU Z7obFHlL+a0UnuOMvBBApipc/jMST+4XhGym8v3AG4Snh5dZScTev8xJdLIRs3Ic pOENcERBXKPibOa77QIcQibRRIdopjVE/LOl5YWpBySc6xHTkQS0VSufPWNwi4ps lHp5Eo12w= Received: from yangwei-T440.lan (unknown [171.223.99.216]) by smtp11 (Coremail) with SMTP id D8CowAA3c1ETf2VcM2w4DQ--.50990S3; Thu, 14 Feb 2019 22:45:40 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Thu, 14 Feb 2019 22:45:38 +0800 Message-Id: <1550155538-4253-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: D8CowAA3c1ETf2VcM2w4DQ--.50990S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF13Cw17Cw4rZw1kZrb_yoWfXrb_ur 17Zr4xGw4UArs0gw4jkF4F9a4FvF1rXrZ5A34xK3y5t39rWr15A3yDZrnrGF1fW398Jr9r Ar9Iv398Z34jvjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0rbbtUUUUU== X-Originating-IP: [171.223.99.216] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiERRbolWBkLMckwAAsE Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in i596_interrupt() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/i825xx/lib82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/lib82596.c b/drivers/net/ethernet/i825xx/lib82596.c index 2f7ae11..1274ad2 100644 --- a/drivers/net/ethernet/i825xx/lib82596.c +++ b/drivers/net/ethernet/i825xx/lib82596.c @@ -1194,7 +1194,7 @@ static irqreturn_t i596_interrupt(int irq, void *dev_id) dma_unmap_single(dev->dev.parent, tx_cmd->dma_addr, skb->len, DMA_TO_DEVICE); - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); tx_cmd->cmd.command = 0; /* Mark free */ break; -- 2.7.4