From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9989C43381 for ; Thu, 14 Feb 2019 14:51:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89F572229F for ; Thu, 14 Feb 2019 14:51:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="KWx1wnt7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439323AbfBNOvb (ORCPT ); Thu, 14 Feb 2019 09:51:31 -0500 Received: from m12-15.163.com ([220.181.12.15]:59255 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404278AbfBNOvS (ORCPT ); Thu, 14 Feb 2019 09:51:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=nI6UVgNT1TIwVZSX96 CmJhCYP1GFmwa38QXCe6fIGRg=; b=KWx1wnt7XkjdIim+Da+ifeRD+j7JDNg4h2 jE9090PLe64qqi/lhHFD3VgJM56dfBq3gJ2qaJo6wFrrg5XOPnySaXfrtIc7I1dh VOwRLnAWW6Q00FIk8oecSH5Fj1CEO99ZpkkZPObEYUwwZlOF8us4v0HOxbgrjdjz lOB7u6Yx4= Received: from yangwei-T440.lan (unknown [171.223.99.216]) by smtp11 (Coremail) with SMTP id D8CowABH9CFZgGVcJ0c5DQ--.9065S3; Thu, 14 Feb 2019 22:51:06 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, michal.simek@xilinx.com, anirudh@xilinx.com, John.Linn@xilinx.com, radhey.shyam.pandey@xilinx.com, andrew@lunn.ch, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: xilinx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Thu, 14 Feb 2019 22:50:58 +0800 Message-Id: <1550155858-4340-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: D8CowABH9CFZgGVcJ0c5DQ--.9065S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrWDZw4kAF4UAryDJw4rAFb_yoW8KF1rpF WUJa48Crs7JFWUXwn7Gw4Yv3Z8ZayI9a4kKFZ8Ka93ZrnxArZ5Ja1YkFsagrWUZrW0gFW7 tr1Yv34fGFnxX37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jI89tUUUUU= X-Originating-IP: [171.223.99.216] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiShRbolPAC-cfewAAss Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 15bb058..44efffb 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -630,7 +630,7 @@ static void temac_start_xmit_done(struct net_device *ndev) dma_unmap_single(ndev->dev.parent, cur_p->phys, cur_p->len, DMA_TO_DEVICE); if (cur_p->app4) - dev_kfree_skb_irq((struct sk_buff *)cur_p->app4); + dev_consume_skb_irq((struct sk_buff *)cur_p->app4); cur_p->app0 = 0; cur_p->app1 = 0; cur_p->app2 = 0; diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 0789d8a..ec7e7ec 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -595,7 +595,7 @@ static void axienet_start_xmit_done(struct net_device *ndev) (cur_p->cntrl & XAXIDMA_BD_CTRL_LENGTH_MASK), DMA_TO_DEVICE); if (cur_p->app4) - dev_kfree_skb_irq((struct sk_buff *)cur_p->app4); + dev_consume_skb_irq((struct sk_buff *)cur_p->app4); /*cur_p->phys = 0;*/ cur_p->app0 = 0; cur_p->app1 = 0; diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 639e3e9..b03a417 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -581,7 +581,7 @@ static void xemaclite_tx_handler(struct net_device *dev) return; dev->stats.tx_bytes += lp->deferred_skb->len; - dev_kfree_skb_irq(lp->deferred_skb); + dev_consume_skb_irq(lp->deferred_skb); lp->deferred_skb = NULL; netif_trans_update(dev); /* prevent tx timeout */ netif_wake_queue(dev); -- 2.7.4