From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 665A8C43381 for ; Thu, 14 Feb 2019 14:52:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33A8B222D9 for ; Thu, 14 Feb 2019 14:52:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="gEsDEPsO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439444AbfBNOwh (ORCPT ); Thu, 14 Feb 2019 09:52:37 -0500 Received: from m12-11.163.com ([220.181.12.11]:36435 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439446AbfBNOwg (ORCPT ); Thu, 14 Feb 2019 09:52:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=DLyC3tD7wTdmS721Uq gE8KaMPDovl4YmE0QaHdzrTk0=; b=gEsDEPsO+kUvc+qkFRqcYY0Kk9x+YB8LWO GwqYoYIyP2ywjNPzqVK3OH3fG7RKyoKrSnXR+WERqvgYKGgM2e3+ZPvdgurY6Gcg ldwmEXmBKO51KDHpL4pAs+2B3kAfx/+mkmAJ2o6PHDd8/+PDq9YKPpv0MNC9y+il rUIKMYppU= Received: from yangwei-T440.lan (unknown [171.223.99.216]) by smtp7 (Coremail) with SMTP id C8CowACHxZKtgGVcyR6mFg--.30293S3; Thu, 14 Feb 2019 22:52:30 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: packetengines: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Thu, 14 Feb 2019 22:52:28 +0800 Message-Id: <1550155948-4404-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: C8CowACHxZKtgGVcyR6mFg--.30293S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrWDZw4fCr1kKrWxZF13urg_yoW8Zry8pF WjkrWqvw1xJw1UJ3Z5tws7WFn8Xay3tr97WFy3Wws3u3sFyrs8tr1vkFy29rWDZr4DJw12 ya90va4S9FZ8t3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jcvtZUUUUU= X-Originating-IP: [171.223.99.216] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiLw5bolUMKp53VAAAsW Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/packetengines/hamachi.c | 2 +- drivers/net/ethernet/packetengines/yellowfin.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/packetengines/hamachi.c b/drivers/net/ethernet/packetengines/hamachi.c index c9529c2..eee883a 100644 --- a/drivers/net/ethernet/packetengines/hamachi.c +++ b/drivers/net/ethernet/packetengines/hamachi.c @@ -1337,7 +1337,7 @@ static irqreturn_t hamachi_interrupt(int irq, void *dev_instance) leXX_to_cpu(hmp->tx_ring[entry].addr), skb->len, PCI_DMA_TODEVICE); - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); hmp->tx_skbuff[entry] = NULL; } hmp->tx_ring[entry].status_n_length = 0; diff --git a/drivers/net/ethernet/packetengines/yellowfin.c b/drivers/net/ethernet/packetengines/yellowfin.c index 54224d1..6f8d658 100644 --- a/drivers/net/ethernet/packetengines/yellowfin.c +++ b/drivers/net/ethernet/packetengines/yellowfin.c @@ -925,7 +925,7 @@ static irqreturn_t yellowfin_interrupt(int irq, void *dev_instance) /* Free the original skb. */ pci_unmap_single(yp->pci_dev, le32_to_cpu(yp->tx_ring[entry].addr), skb->len, PCI_DMA_TODEVICE); - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); yp->tx_skbuff[entry] = NULL; } if (yp->tx_full && @@ -983,7 +983,7 @@ static irqreturn_t yellowfin_interrupt(int irq, void *dev_instance) pci_unmap_single(yp->pci_dev, yp->tx_ring[entry<<1].addr, skb->len, PCI_DMA_TODEVICE); - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); yp->tx_skbuff[entry] = 0; /* Mark status as empty. */ yp->tx_status[entry].tx_errs = 0; -- 2.7.4