From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE6EC43381 for ; Thu, 14 Feb 2019 15:07:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BABF222C9 for ; Thu, 14 Feb 2019 15:07:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="iISN8Uj5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2501887AbfBNPHA (ORCPT ); Thu, 14 Feb 2019 10:07:00 -0500 Received: from m12-17.163.com ([220.181.12.17]:49229 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387401AbfBNPG7 (ORCPT ); Thu, 14 Feb 2019 10:06:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=vr6xCb2ta3YrK7lcSc RukdGF03QJZsczWIj4gEi1GAY=; b=iISN8Uj52HnbLoxtYHhab0SeEdfE3B4GBk cEbVe6MwynDLO8QFYzwD4L0paYCMW2S8CFR/8she2i9qtFoTyamUuUe9beevWS57 bFkadabBv3V880LnLiDLwLwu4qwMEbLHnRGF0uH11P4vB+rJkVu3e11GLExJUSc0 mrMgdLtfU= Received: from yangwei-T440.lan (unknown [171.223.99.216]) by smtp13 (Coremail) with SMTP id EcCowADXJsYBhGVcZutiFw--.45611S3; Thu, 14 Feb 2019 23:06:42 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, ionut@badula.org, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: adaptec: starfire: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Thu, 14 Feb 2019 23:06:40 +0800 Message-Id: <1550156800-4821-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: EcCowADXJsYBhGVcZutiFw--.45611S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF48tw48Kr4rKrWfKrg_yoW3Krg_Ww 18Z3WxWw4UuFya9w47KFs5ZFyS9w4DXF48AFs5KFWrt34UKr1DZFWDXr93GrnxWw4DAF9r WasxZrW3u3y5tjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8Hlk7UUUUU== X-Originating-IP: [171.223.99.216] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiRQNboll9ox8ruQAAs1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in intr_handler() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/adaptec/starfire.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/adaptec/starfire.c b/drivers/net/ethernet/adaptec/starfire.c index 097467f..816540e 100644 --- a/drivers/net/ethernet/adaptec/starfire.c +++ b/drivers/net/ethernet/adaptec/starfire.c @@ -1390,7 +1390,7 @@ static irqreturn_t intr_handler(int irq, void *dev_instance) } } - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); } np->tx_done_q[np->tx_done].status = 0; np->tx_done = (np->tx_done + 1) % DONE_Q_SIZE; -- 2.7.4