From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE03C43381 for ; Tue, 19 Feb 2019 10:31:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13CDA20818 for ; Tue, 19 Feb 2019 10:31:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="XJrw4gHU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728327AbfBSKbf (ORCPT ); Tue, 19 Feb 2019 05:31:35 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:46877 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728299AbfBSKbb (ORCPT ); Tue, 19 Feb 2019 05:31:31 -0500 Received: by mail-pl1-f194.google.com with SMTP id o6so10236683pls.13 for ; Tue, 19 Feb 2019 02:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YdkEf+0PgIV9/FLGP1P2EIwkJynYwYa1SNdqh5XWm0c=; b=XJrw4gHU4fEvgk/So6TfLY/9XoJ1LHMTQN03fDwucCm9Wb8sQ6cBeY5pl9C/d3nHZp WSXzVwZZ6ySqyvvt/kp9fuphdtmvGpIiQGllwBRK5SUsctCgYK6XbMCrg2S2NPx3h6bv t60KUkZcjzj43e+j9Rx6D3huTPrC3W4xuWuGM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YdkEf+0PgIV9/FLGP1P2EIwkJynYwYa1SNdqh5XWm0c=; b=hPlaIeGS+VeaXz9WEGNiKPIE/ArQ2oWWQlBeutY6vLrtYq174yTHZ+VzYx2EYoT7F5 ucyT6og9p0hCLEJS3H6EXhYsDtGTiVhGLNeUEO5ZO/2zgn2IvtLDKUTIbjBgf0/rX4vQ 8iYDoKqAhbbOKnLbVWM/y5b5uEmg4ANs0WQjueuy08kZtIHo0huKVjU1WW5JNNSCMSfH o2zSPyLfmzhnpdCfMUZBKn/qB9TxBw90NfSghbCHo8ntxQPMG/TOwPUtRqoH3RUPJA8z SZP1zq+FXOYLfL45UCbXOrTSY65cwhpgp2FCeJmiJmea8wOndgaj+/yxIPiIODxZgp9c rGZQ== X-Gm-Message-State: AHQUAub03Fhb49QftUZdYyI3VatA0sbxCDCxsKmqSDHyxDRKSGY0BFos 3jHyQ3oOXdShFBCgJ5lPVJPLCQ== X-Google-Smtp-Source: AHgI3IbFHOV5w0WwvbdJn1dHr2opIftBPbDxliud1qTxzwxM3KFAxq3Ls/FhpbDfE+UKYXgiznErMQ== X-Received: by 2002:a17:902:74cb:: with SMTP id f11mr27954850plt.180.1550572291012; Tue, 19 Feb 2019 02:31:31 -0800 (PST) Received: from localhost.dhcp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id f12sm19198952pgo.13.2019.02.19.02.31.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 02:31:30 -0800 (PST) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org Subject: [PATCH net-next 5/5] bnxt_en: Return relevant error code when offload fails Date: Tue, 19 Feb 2019 05:31:16 -0500 Message-Id: <1550572276-14711-6-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1550572276-14711-1-git-send-email-michael.chan@broadcom.com> References: <1550572276-14711-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sriharsha Basavapatna The driver returns -ENOSPC when tc_can_offload() check fails. Since that routine checks for flow parameters that are not supported by the driver, we should return the more appropriate -EOPNOTSUPP. Signed-off-by: Sriharsha Basavapatna Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c index 61a3457..44d6c57 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c @@ -1290,7 +1290,7 @@ static int bnxt_tc_add_flow(struct bnxt *bp, u16 src_fid, bnxt_tc_set_flow_dir(bp, flow, src_fid); if (!bnxt_tc_can_offload(bp, flow)) { - rc = -ENOSPC; + rc = -EOPNOTSUPP; goto free_node; } -- 2.5.1