From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E5FC43381 for ; Mon, 25 Feb 2019 15:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC8152087C for ; Mon, 25 Feb 2019 15:02:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="eQBNVGby" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727588AbfBYPCC (ORCPT ); Mon, 25 Feb 2019 10:02:02 -0500 Received: from m12-15.163.com ([220.181.12.15]:59252 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727496AbfBYPCC (ORCPT ); Mon, 25 Feb 2019 10:02:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=/HXEfsnr1A8jlHR8yu LZGWo6ytAlLB8zH8XgMrSul9Q=; b=eQBNVGbypj0tXUAAewSzcumqxHTH2FhnvZ fjKcJfk5j34hA3rjmtU37oL8I8QmRyq1zCtfBU3cCZZIISsoROiMdtjooK0FvsfK 2euT+GW5o4MBoUAV6lbinp7yaLMjTulLebKcw7zRpq/ETW/597s+OcWemdV0rCGI f09rHnHi8= Received: from yangwei-T440.lan (unknown [171.223.98.171]) by smtp11 (Coremail) with SMTP id D8CowAB3KjxfA3RcFmxSEw--.19832S3; Mon, 25 Feb 2019 23:01:52 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: khc@pm.waw.pl, davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net-next] net: wan: wanxl: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Mon, 25 Feb 2019 23:01:50 +0800 Message-Id: <1551106910-16515-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: D8CowAB3KjxfA3RcFmxSEw--.19832S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF47AF4rZFWUuFyUKFg_yoW3trc_Cw 1Dtw4fXw4UGFy3Kw18K3WYvFyYv3WrXF48Zr92gFW3t3yUArW3ZrWfW3ZrGw1Ykw4UZr12 k342vF4jq343JjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8NeOPUUUUU== X-Originating-IP: [171.223.98.171] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/xtbB0wBmolXli2AHKwAAsg Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in wanxl_tx_intr() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/wan/wanxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index d573a57..5c234a6 100644 --- a/drivers/net/wan/wanxl.c +++ b/drivers/net/wan/wanxl.c @@ -185,7 +185,7 @@ static inline void wanxl_tx_intr(struct port *port) desc->stat = PACKET_EMPTY; /* Free descriptor */ pci_unmap_single(port->card->pdev, desc->address, skb->len, PCI_DMA_TODEVICE); - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); port->tx_in = (port->tx_in + 1) % TX_BUFFERS; } } -- 2.7.4