From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554A0C43381 for ; Mon, 25 Feb 2019 15:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2385C213A2 for ; Mon, 25 Feb 2019 15:03:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="VVBbaHXB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727625AbfBYPDs (ORCPT ); Mon, 25 Feb 2019 10:03:48 -0500 Received: from m12-18.163.com ([220.181.12.18]:51527 "EHLO m12-18.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727490AbfBYPDr (ORCPT ); Mon, 25 Feb 2019 10:03:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=nrFEV7JoJSP1crEB9+ HYZU0Mbo9c1JrFZmVg+FKHJj8=; b=VVBbaHXBApQvwtofBwOJB5Kct2snNZHay1 FcB5GmYzzOJpofW3VDbCXBuYS55eKGkGubdini1e1MbO9jHm2h05+cqCRBT1GOhW tiQuvaoHC9NF+dZZh21cmVaBrYP5rqjdY1MkKQB8dl6y4UFoD1pcgLkivpmeaW7j tqGlZ8OOY= Received: from yangwei-T440.lan (unknown [171.223.98.171]) by smtp14 (Coremail) with SMTP id EsCowADn9_fNA3RctusJHQ--.20281S3; Mon, 25 Feb 2019 23:03:42 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net-next] net: wan: sbni: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Mon, 25 Feb 2019 23:03:40 +0800 Message-Id: <1551107020-16629-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: EsCowADn9_fNA3RctusJHQ--.20281S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF48tw48KryfGrWfXwb_yoW3GrgE93 srur1xXr1UJryqgw1jgFsavr9Yy3Z8XF48uryIqrWfXa4jvr90krZ3XF9rGr9xKws7WFya kFnrXF4Du3y3JjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8txhPUUUUU== X-Originating-IP: [171.223.98.171] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiEQ5molWBkVhdvAAAsn Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in send_complete() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/wan/sbni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/sbni.c b/drivers/net/wan/sbni.c index 8e8c4c0..40c04ea 100644 --- a/drivers/net/wan/sbni.c +++ b/drivers/net/wan/sbni.c @@ -761,7 +761,7 @@ send_complete( struct net_device *dev ) dev->stats.tx_packets++; dev->stats.tx_bytes += nl->tx_buf_p->len; #endif - dev_kfree_skb_irq( nl->tx_buf_p ); + dev_consume_skb_irq(nl->tx_buf_p); nl->tx_buf_p = NULL; -- 2.7.4