From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC4BC43381 for ; Mon, 25 Feb 2019 15:06:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E0152087C for ; Mon, 25 Feb 2019 15:06:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="CSW+KOnR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727570AbfBYPGQ (ORCPT ); Mon, 25 Feb 2019 10:06:16 -0500 Received: from m12-17.163.com ([220.181.12.17]:59050 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726675AbfBYPGQ (ORCPT ); Mon, 25 Feb 2019 10:06:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=ExdZ2ARnhPlIpHwFTr z5reQRuF6oJDpsW1zVpYxny6s=; b=CSW+KOnRgiEgT+cACkUzNBqmcZrLazIB5e S1+LJguCyKCvpkNOPKTSPa/Y/RWTNIYAX3py7n31LiTl/eaHWs+M4lY+D3qjqt0a ECZz02URPBS78lGzws+9CvDcihK/X5bS+NRVT5IT9hKDFLmkLO5AONblOHPyQKvM 1YjbOn7w8= Received: from yangwei-T440.lan (unknown [171.223.98.171]) by smtp13 (Coremail) with SMTP id EcCowABnt9dGBHRcLQbLHQ--.48413S3; Mon, 25 Feb 2019 23:05:43 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: kas@fi.muni.cz, davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net-next] net: wan: cosa: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Mon, 25 Feb 2019 23:05:41 +0800 Message-Id: <1551107141-16702-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: EcCowABnt9dGBHRcLQbLHQ--.48413S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF48tw48uw4DJr4DCFg_yoW3tFgEg3 yxuFW7Xr4UGr9Yyw4qgFWYvFyayFy5Xr4kZr92v3yfJ34Dtr17trZYqrn3C3sYg3y3uF9r KFWDZFsYgry8JjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8upB3UUUUU== X-Originating-IP: [171.223.98.171] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiSg5molPADJx6hAABs8 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in cosa_net_tx_done() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/wan/cosa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c index f6b000d..55f76e4 100644 --- a/drivers/net/wan/cosa.c +++ b/drivers/net/wan/cosa.c @@ -769,7 +769,7 @@ static int cosa_net_tx_done(struct channel_data *chan, int size) chan->netdev->stats.tx_aborted_errors++; return 1; } - dev_kfree_skb_irq(chan->tx_skb); + dev_consume_skb_irq(chan->tx_skb); chan->tx_skb = NULL; chan->netdev->stats.tx_packets++; chan->netdev->stats.tx_bytes += size; -- 2.7.4