From: Aya Levin <ayal@mellanox.com>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>,
Aya Levin <ayal@mellanox.com>
Subject: [PATCH v4 iproute2-next 06/11] devlink: Add devlink health recover command
Date: Thu, 28 Feb 2019 14:12:59 +0200 [thread overview]
Message-ID: <1551355984-15752-7-git-send-email-ayal@mellanox.com> (raw)
In-Reply-To: <1551355984-15752-1-git-send-email-ayal@mellanox.com>
Add devlink health recover command which enables the user to initiate a
recovery on a reporter (if a recovery cb was supplied by the reporter).
This operation will increment the recoveries counter displayed in the
show command.
Example:
$ devlink health recover pci/0000:00:09.0 reporter tx
Signed-off-by: Aya Levin <ayal@mellanox.com>
Reviewed-by: Moshe Shemesh <moshe@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
---
devlink/devlink.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index 37eb2054ef06..c77f80c87adc 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -5815,6 +5815,23 @@ static int cmd_region(struct dl *dl)
return -ENOENT;
}
+static int cmd_health_recover(struct dl *dl)
+{
+ struct nlmsghdr *nlh;
+ int err;
+
+ nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_HEALTH_REPORTER_RECOVER,
+ NLM_F_REQUEST | NLM_F_ACK);
+
+ err = dl_argv_parse_put(nlh, dl,
+ DL_OPT_HANDLE | DL_OPT_HEALTH_REPORTER_NAME, 0);
+ if (err)
+ return err;
+
+ dl_opts_put(nlh, dl);
+ return _mnlg_socket_sndrcv(dl->nlg, nlh, NULL, NULL);
+}
+
enum devlink_health_reporter_state {
DEVLINK_HEALTH_REPORTER_STATE_HEALTHY,
DEVLINK_HEALTH_REPORTER_STATE_ERROR,
@@ -5954,6 +5971,7 @@ static int cmd_health_show(struct dl *dl)
static void cmd_health_help(void)
{
pr_err("Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n");
+ pr_err(" devlink health recover DEV reporter REPORTER_NAME\n");
}
static int cmd_health(struct dl *dl)
@@ -5965,6 +5983,9 @@ static int cmd_health(struct dl *dl)
dl_argv_match(dl, "list") || dl_no_arg(dl)) {
dl_arg_inc(dl);
return cmd_health_show(dl);
+ } else if (dl_argv_match(dl, "recover")) {
+ dl_arg_inc(dl);
+ return cmd_health_recover(dl);
}
pr_err("Command \"%s\" not found\n", dl_argv(dl));
return -ENOENT;
--
2.14.1
next prev parent reply other threads:[~2019-02-28 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 12:12 [PATCH v4 iproute2-next 00/11] Add support for devlink health Aya Levin
2019-02-28 12:12 ` [PATCH v4 iproute2-next 01/11] devlink: Refactor validation of finding required arguments Aya Levin
2019-02-28 12:12 ` [PATCH v4 iproute2-next 02/11] devlink: Fix print of uint64_t Aya Levin
2019-02-28 12:12 ` [PATCH v4 iproute2-next 03/11] devlink: Fix boolean JSON print Aya Levin
2019-02-28 12:12 ` [PATCH v4 iproute2-next 04/11] devlink: Add helper functions for name and value separately Aya Levin
2019-02-28 12:12 ` [PATCH v4 iproute2-next 05/11] devlink: Add devlink health show command Aya Levin
2019-02-28 12:12 ` Aya Levin [this message]
2019-02-28 12:13 ` [PATCH v4 iproute2-next 07/11] devlink: Add devlink health diagnose command Aya Levin
2019-02-28 12:13 ` [PATCH v4 iproute2-next 08/11] devlink: Add devlink health dump show command Aya Levin
2019-02-28 12:13 ` [PATCH v4 iproute2-next 09/11] devlink: Add devlink health dump clear command Aya Levin
2019-02-28 12:13 ` [PATCH v4 iproute2-next 10/11] devlink: Add devlink health set command Aya Levin
2019-02-28 12:13 ` [PATCH v4 iproute2-next 11/11] devlink: Add devlink-health man page Aya Levin
2019-02-28 16:01 ` [PATCH v4 iproute2-next 00/11] Add support for devlink health David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551355984-15752-7-git-send-email-ayal@mellanox.com \
--to=ayal@mellanox.com \
--cc=dsahern@gmail.com \
--cc=eranbe@mellanox.com \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox