From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8BBC43381 for ; Fri, 1 Mar 2019 19:08:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 742DD20663 for ; Fri, 1 Mar 2019 19:08:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387949AbfCATIu (ORCPT ); Fri, 1 Mar 2019 14:08:50 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:51154 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1733009AbfCATIu (ORCPT ); Fri, 1 Mar 2019 14:08:50 -0500 X-UUID: 5a9cd98d316d4f8ab8fc00f4beb55898-20190302 X-UUID: 5a9cd98d316d4f8ab8fc00f4beb55898-20190302 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1314447922; Sat, 02 Mar 2019 03:08:45 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 2 Mar 2019 03:08:43 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 2 Mar 2019 03:08:43 +0800 Message-ID: <1551467323.5127.1.camel@mtkswgap22> Subject: Re: [PATCH net-next] drivers: net: Remove unnecessary semicolon From: Sean Wang To: Yue Haibing CC: , , , , , <_govind@gmx.com>, , , , Date: Sat, 2 Mar 2019 03:08:43 +0800 In-Reply-To: <20190301080900.6656-1-yuehaibing@huawei.com> References: <20190301080900.6656-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-TM-SNTS-SMTP: 0E59B96B09661E98650F0C97611817BAE6F3138A6AFB3D84C79523A47C32C3662000:8 X-MTK: N Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2019-03-01 at 16:09 +0800, Yue Haibing wrote: > From: YueHaibing > > drivers/net/dsa/mt7530.c:649:3-4: Unneeded semicolon > drivers/net/ethernet/cisco/enic/enic_clsf.c:35:2-3: Unneeded semicolon > drivers/net/ethernet/faraday/ftgmac100.c:1640:2-3: Unneeded semicolon > drivers/net/ethernet/mediatek/mtk_eth_soc.c:229:2-3: Unneeded semicolon > drivers/net/usb/sr9700.c:437:2-3: Unneeded semicolon > > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > Acked-by: Sean Wang for mt7530 and mtk_eth_soc thanks! > Signed-off-by: YueHaibing > --- > drivers/net/dsa/mt7530.c | 2 +- > drivers/net/ethernet/cisco/enic/enic_clsf.c | 3 ++- > drivers/net/ethernet/faraday/ftgmac100.c | 2 +- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- > drivers/net/usb/sr9700.c | 2 +- > 5 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 0390c5e..7357b4f 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -646,7 +646,7 @@ static void mt7530_adjust_link(struct dsa_switch *ds, int port, > case SPEED_100: > mcr |= PMCR_FORCE_SPEED_100; > break; > - }; > + } > > if (phydev->link) > mcr |= PMCR_FORCE_LNK; > diff --git a/drivers/net/ethernet/cisco/enic/enic_clsf.c b/drivers/net/ethernet/cisco/enic/enic_clsf.c > index 99038df..9900993 100644 > --- a/drivers/net/ethernet/cisco/enic/enic_clsf.c > +++ b/drivers/net/ethernet/cisco/enic/enic_clsf.c > @@ -32,7 +32,8 @@ int enic_addfltr_5t(struct enic *enic, struct flow_keys *keys, u16 rq) > break; > default: > return -EPROTONOSUPPORT; > - }; > + } > + > data.type = FILTER_IPV4_5TUPLE; > data.u.ipv4.src_addr = ntohl(keys->addrs.v4addrs.src); > data.u.ipv4.dst_addr = ntohl(keys->addrs.v4addrs.dst); > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c > index 3e5e971..b17b79e 100644 > --- a/drivers/net/ethernet/faraday/ftgmac100.c > +++ b/drivers/net/ethernet/faraday/ftgmac100.c > @@ -1637,7 +1637,7 @@ static int ftgmac100_setup_mdio(struct net_device *netdev) > reg = ioread32(priv->base + FTGMAC100_OFFSET_REVR); > reg &= ~FTGMAC100_REVR_NEW_MDIO_INTERFACE; > iowrite32(reg, priv->base + FTGMAC100_OFFSET_REVR); > - }; > + } > > /* Get PHY mode from device-tree */ > if (np) { > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 94d4663..549d364 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -226,7 +226,7 @@ static void mtk_phy_link_adjust(struct net_device *dev) > case SPEED_100: > mcr |= MAC_MCR_SPEED_100; > break; > - }; > + } > > if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_GMAC1_TRGMII) && > !mac->id && !mac->trgmii) > diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c > index 6ac232e..e04c8054 100644 > --- a/drivers/net/usb/sr9700.c > +++ b/drivers/net/usb/sr9700.c > @@ -434,7 +434,7 @@ static int sr9700_rx_fixup(struct usbnet *dev, struct sk_buff *skb) > usbnet_skb_return(dev, sr_skb); > > skb_pull(skb, len + SR_RX_OVERHEAD); > - }; > + } > > return 0; > }