From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
Subject: Re: [PATCH][next] batman-adv: don't pass a NULL
 hard_iface to batadv_hardif_put
Date: Sat, 24 Mar 2018 10:36:15 +0100
Message-ID: <1552330.yTaGxcYA6e@sven-edge>
References: <20180323225350.7350-1-colin.king@canonical.com>
Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking
 <b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1524434.qlbeyyzbMd";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Marek Lindner <mareklindner-rVWd3aGhH2z5bpWLKbzFeg@public.gmane.org>,
 netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Antonio Quartulli <a@unstable.cc>,
 linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Colin King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
 "David S . Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org
Return-path: <b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org>
In-Reply-To: <20180323225350.7350-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org?subject=unsubscribe>
List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/>
List-Post: <mailto:b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org>
List-Help: <mailto:b.a.t.m.a.n-request-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org?subject=help>
List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org?subject=subscribe>
Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org
Sender: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org>
List-Id: netdev.vger.kernel.org

--nextPart1524434.qlbeyyzbMd
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Freitag, 23. M=E4rz 2018 23:53:50 CET Colin King wrote:
> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>=20
> In the case where hard_iface is NULL, the error path may pass a null
> pointer to batadv_hardif_put causing a null pointer dereference error.
> Avoid this by only calling the function if  hard_iface not null.
>=20
> Detected by CoverityScan, CID#1466456 ("Explicit null dereferenced")
>=20
> Fixes: 53dd9a68ba68 ("batman-adv: add multicast flags netlink support")
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> ---
>  net/batman-adv/multicast.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Queued up for David in batadv/net-next as d5863c47d725 [1]

Now I only have to find out why I didn't receive the mail about this=20
from coverity.

Thanks,
	Sven

[1] https://git.open-mesh.org/linux-merge.git/commit/d5863c47d7255448ec0171=
3cbdb4f94b370d86ad
--nextPart1524434.qlbeyyzbMd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlq2HA8ACgkQXYcKB8Em
e0a3UhAA1jf+py/wrYYigdPHLlWb8Sbh6grH14VWxKIvqbAoTegxIp6i97/HuoJ/
CHZoOzFzzGm7zpuNDTLIMhn9ltRKiYLdG4gOWqc/zQnwQvegaA9GGxUN6rn2qCo9
B49zyESlAS7AReauoGJVycydYvp7RspbMRamYOd2g6HE0J1N8BquHdyJqIhYUs8c
lXSZ90GCrguSjWIOzJfm2YOqKKDNRLxqOLEuO+UsqjEN9T/ZA6wn8pdWcH32aRPt
sG2RuP4p1mEPpsRksxPr4XbNvqfWnQfybuqLf3WCq/4yMbkA9s4O2hRiqKc/wj5o
fcQXd3fobm+5dHHd9uhBqz0Pop30lmrULhwv3zrzysu+yVHekGMlHf9696wsuXAD
ibOhgFOCkFELgDVAkrDZWVM9r2igFYMbc5igmNZx7gzRPWk04IBWAEyi28K/ptrN
AsieFJ13vbfSGcvCK972MUTKrUJSuYhyd67GToMvN3fx/l2gaiwFllh1jMeTIU5B
Xc0zhtOWocBqJaw4UKPJ5OodxBKINmfJ0JJYyrb7LejIWksxBygcxHeGUnJPmrYu
MsOnQDmq5fgeeQz6KUZRxC1dNu3CTetXFWOC2cep7Isl1P3qBmnxwUIVSoXXVNEw
OdIPtMwX1NLwVSz+wVAWRQE0JriUbSR/R/5J8/AdzsdpSjQ9WS4=
=IINO
-----END PGP SIGNATURE-----

--nextPart1524434.qlbeyyzbMd--