* [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet
@ 2019-03-19 14:31 Jeff Xie
2019-03-20 2:31 ` Pkshih
2019-04-04 10:27 ` [PATCH] rtlwifi: move " Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Xie @ 2019-03-19 14:31 UTC (permalink / raw)
To: pkshih, kvalo; +Cc: davem, linux-wireless, netdev, linux-kernel, chongguiguzi
It is unnecessary to call spin_lock_bh in a tasklet.
Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c
index 48ca521..4055e0a 100644
--- a/drivers/net/wireless/realtek/rtlwifi/pci.c
+++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
@@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw *hw)
memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
- spin_lock_bh(&rtlpriv->locks.waitq_lock);
+ spin_lock(&rtlpriv->locks.waitq_lock);
if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
(ring->entries - skb_queue_len(&ring->queue) >
rtlhal->max_earlymode_num)) {
skb = skb_dequeue(&mac->skb_waitq[tid]);
} else {
- spin_unlock_bh(&rtlpriv->locks.waitq_lock);
+ spin_unlock(&rtlpriv->locks.waitq_lock);
break;
}
- spin_unlock_bh(&rtlpriv->locks.waitq_lock);
+ spin_unlock(&rtlpriv->locks.waitq_lock);
/* Some macaddr can't do early mode. like
* multicast/broadcast/no_qos data
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet
2019-03-19 14:31 [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet Jeff Xie
@ 2019-03-20 2:31 ` Pkshih
2019-03-20 2:41 ` 谢欢
2019-04-04 10:27 ` [PATCH] rtlwifi: move " Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Pkshih @ 2019-03-20 2:31 UTC (permalink / raw)
To: kvalo@codeaurora.org, chongguiguzi@gmail.com
Cc: linux-wireless@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote:
> It is unnecessary to call spin_lock_bh in a tasklet.
>
> Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
>
> ---
> drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
> b/drivers/net/wireless/realtek/rtlwifi/pci.c
> index 48ca521..4055e0a 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw
> *hw)
>
> memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
>
> - spin_lock_bh(&rtlpriv->locks.waitq_lock);
> + spin_lock(&rtlpriv->locks.waitq_lock);
> if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
> (ring->entries - skb_queue_len(&ring->queue) >
> rtlhal->max_earlymode_num)) {
> skb = skb_dequeue(&mac->skb_waitq[tid]);
> } else {
> - spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> + spin_unlock(&rtlpriv->locks.waitq_lock);
> break;
> }
> - spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> + spin_unlock(&rtlpriv->locks.waitq_lock);
>
> /* Some macaddr can't do early mode. like
> * multicast/broadcast/no_qos data
The mail subject should be 'rtlwifi: move ....', and the other looks good to me.
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet
2019-03-20 2:31 ` Pkshih
@ 2019-03-20 2:41 ` 谢欢
0 siblings, 0 replies; 4+ messages in thread
From: 谢欢 @ 2019-03-20 2:41 UTC (permalink / raw)
To: Pkshih
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Thank you so much for your useful advice.
Pkshih <pkshih@realtek.com> 于2019年3月20日周三 上午10:31写道：
>
> On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote:
> > It is unnecessary to call spin_lock_bh in a tasklet.
> >
> > Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
> >
> > ---
> > drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
> > b/drivers/net/wireless/realtek/rtlwifi/pci.c
> > index 48ca521..4055e0a 100644
> > --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> > +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> > @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw
> > *hw)
> >
> > memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
> >
> > - spin_lock_bh(&rtlpriv->locks.waitq_lock);
> > + spin_lock(&rtlpriv->locks.waitq_lock);
> > if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
> > (ring->entries - skb_queue_len(&ring->queue) >
> > rtlhal->max_earlymode_num)) {
> > skb = skb_dequeue(&mac->skb_waitq[tid]);
> > } else {
> > - spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> > + spin_unlock(&rtlpriv->locks.waitq_lock);
> > break;
> > }
> > - spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> > + spin_unlock(&rtlpriv->locks.waitq_lock);
> >
> > /* Some macaddr can't do early mode. like
> > * multicast/broadcast/no_qos data
>
> The mail subject should be 'rtlwifi: move ....', and the other looks good to me.
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtlwifi: move spin_lock_bh to spin_lock in tasklet
2019-03-19 14:31 [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet Jeff Xie
2019-03-20 2:31 ` Pkshih
@ 2019-04-04 10:27 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-04-04 10:27 UTC (permalink / raw)
To: Jeff Xie
Cc: pkshih, davem, linux-wireless, netdev, linux-kernel, chongguiguzi
Jeff Xie <chongguiguzi@gmail.com> wrote:
> It is unnecessary to call spin_lock_bh in a tasklet.
>
> Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
38bb0baea310 rtlwifi: move spin_lock_bh to spin_lock in tasklet
--
https://patchwork.kernel.org/patch/10859681/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-04 10:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-19 14:31 [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet Jeff Xie
2019-03-20 2:31 ` Pkshih
2019-03-20 2:41 ` 谢欢
2019-04-04 10:27 ` [PATCH] rtlwifi: move " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).