From: Luca Boccassi <bluca@debian.org>
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next] tools/bpf: generate pkg-config file for libbpf
Date: Tue, 19 Mar 2019 23:02:15 +0000 [thread overview]
Message-ID: <1553036535.28350.2.camel@debian.org> (raw)
In-Reply-To: <20190319212303.GE7431@mini-arch.hsd1.ca.comcast.net>
On Tue, 2019-03-19 at 14:23 -0700, Stanislav Fomichev wrote:
> On 03/19, Luca Boccassi wrote:
> > Generate a libbpf.pc file at build time so that users can rely
> > on pkg-config to find the library, its CFLAGS and LDFLAGS.
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > tools/lib/bpf/.gitignore | 1 +
> > tools/lib/bpf/Makefile | 18 +++++++++++++++---
> > tools/lib/bpf/libbpf.pc.template | 11 +++++++++++
> > 3 files changed, 27 insertions(+), 3 deletions(-)
> > create mode 100644 tools/lib/bpf/libbpf.pc.template
> >
> > diff --git a/tools/lib/bpf/.gitignore b/tools/lib/bpf/.gitignore
> > index 4db74758c674..7d9e182a1f51 100644
> > --- a/tools/lib/bpf/.gitignore
> > +++ b/tools/lib/bpf/.gitignore
> > @@ -1,3 +1,4 @@
> > libbpf_version.h
> > +libbpf.pc
> > FEATURE-DUMP.libbpf
> > test_libbpf
> > diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> > index a05c43468bd0..542c64e2a6d9 100644
> > --- a/tools/lib/bpf/Makefile
> > +++ b/tools/lib/bpf/Makefile
> > @@ -80,6 +80,7 @@ libdir_SQ = $(subst ','\'',$(libdir))
> > libdir_relative_SQ = $(subst ','\'',$(libdir_relative))
> >
> > LIB_FILE = libbpf.a libbpf.so
> > +PC_FILE = libbpf.pc
> >
> > VERSION = $(BPF_VERSION)
> > PATCHLEVEL = $(BPF_PATCHLEVEL)
> > @@ -137,7 +138,7 @@ GLOBAL_SYM_COUNT = $(shell readelf -s --wide
> > $(BPF_IN) | \
> > VERSIONED_SYM_COUNT = $(shell readelf -s --wide $(OUTPUT)libbpf.so
> > | \
> > grep -Eo '[^ ]+@LIBBPF_' | cut -d@
> > -f1 | sort -u | wc -l)
> >
> > -CMD_TARGETS = $(LIB_FILE)
> > +CMD_TARGETS = $(LIB_FILE) $(PC_FILE)
> >
> > CXX_TEST_TARGET = $(OUTPUT)test_libbpf
> >
> > @@ -179,6 +180,12 @@ $(OUTPUT)libbpf.a: $(BPF_IN)
> > $(OUTPUT)test_libbpf: test_libbpf.cpp $(OUTPUT)libbpf.a
> > $(QUIET_LINK)$(CXX) $(INCLUDES) $^ -lelf -o $@
> >
> > +$(OUTPUT)libbpf.pc:
> > + $(QUIET_LINK)sed -e "s|@PREFIX@|$(prefix)|" \
>
> Maybe QUIET_GEN instead? Or QUIET_INSTALL
> (tools/lib/traceevent/Makefile)?
Changed to QUIET_GEN in v2.
> > + -e "s|@LIBDIR@|$(libdir_SQ)|" \
> > + -e "s|@VERSION@|$(shell make --no-print-directory
> > -sC ../../.. kernelversion)|" \
>
> Make it its own variable, like we do in bpftool?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tr
> ee/tools/bpf/bpftool/Makefile#n26
Done in v2.
> Also, I wonder what would happen in the case of out-of-tree libbpf:
> https://github.com/libbpf/libbpf
>
> Should there be some fallback?
That tree looks like it's autosynced from the kernel tree, isn't it?
Then it will just pick up the change and start generating the pc file
as well, won't it?
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2019-03-19 23:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 21:06 [PATCH bpf-next] tools/bpf: generate pkg-config file for libbpf Luca Boccassi
2019-03-19 21:23 ` Stanislav Fomichev
2019-03-19 23:02 ` Luca Boccassi [this message]
2019-03-19 23:12 ` Stanislav Fomichev
2019-03-19 23:00 ` [PATCH bpf-next v2] " Luca Boccassi
2019-03-19 23:17 ` Stanislav Fomichev
2019-03-20 13:22 ` Luca Boccassi
2019-03-20 13:30 ` Luca Boccassi
2019-03-20 17:21 ` Stanislav Fomichev
2019-03-20 20:39 ` Luca Boccassi
2019-03-20 20:44 ` Stanislav Fomichev
2019-03-20 20:54 ` Daniel Borkmann
2019-03-20 21:13 ` Stanislav Fomichev
2019-03-20 13:28 ` [PATCH bpf-next v3] " luca.boccassi
2019-03-20 23:58 ` Andrey Ignatov
2019-03-21 10:29 ` Luca Boccassi
2019-03-21 10:25 ` [PATCH bpf-next v4] " luca.boccassi
2019-03-21 16:00 ` Andrey Ignatov
2019-03-21 22:01 ` Alexei Starovoitov
2019-03-21 22:19 ` Daniel Borkmann
2019-03-21 22:34 ` Luca Boccassi
2019-03-21 22:23 ` Luca Boccassi
2019-03-21 22:27 ` [PATCH bpf-next v5] " luca.boccassi
2019-03-21 22:33 ` [PATCH bpf-next v6] " luca.boccassi
2019-03-21 22:43 ` Alexei Starovoitov
2019-03-21 23:10 ` Luca Boccassi
2019-03-21 23:09 ` [PATCH bpf-next v7] " luca.boccassi
2019-03-26 20:12 ` Alexei Starovoitov
2019-03-26 20:17 ` Luca Boccassi
2019-03-28 11:33 ` [PATCH bpf-next v8] " luca.boccassi
2019-03-28 16:09 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553036535.28350.2.camel@debian.org \
--to=bluca@debian.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).