From: Pkshih <pkshih@realtek.com>
To: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"chongguiguzi@gmail.com" <chongguiguzi@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet
Date: Wed, 20 Mar 2019 02:31:24 +0000 [thread overview]
Message-ID: <1553049084.13542.2.camel@realtek.com> (raw)
In-Reply-To: <1553005870-28018-1-git-send-email-chongguiguzi@gmail.com>
On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote:
> It is unnecessary to call spin_lock_bh in a tasklet.
>
> Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
>
> ---
> drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
> b/drivers/net/wireless/realtek/rtlwifi/pci.c
> index 48ca521..4055e0a 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw
> *hw)
>
> memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
>
> - spin_lock_bh(&rtlpriv->locks.waitq_lock);
> + spin_lock(&rtlpriv->locks.waitq_lock);
> if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
> (ring->entries - skb_queue_len(&ring->queue) >
> rtlhal->max_earlymode_num)) {
> skb = skb_dequeue(&mac->skb_waitq[tid]);
> } else {
> - spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> + spin_unlock(&rtlpriv->locks.waitq_lock);
> break;
> }
> - spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> + spin_unlock(&rtlpriv->locks.waitq_lock);
>
> /* Some macaddr can't do early mode. like
> * multicast/broadcast/no_qos data
The mail subject should be 'rtlwifi: move ....', and the other looks good to me.
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2019-03-20 2:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 14:31 [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet Jeff Xie
2019-03-20 2:31 ` Pkshih [this message]
2019-03-20 2:41 ` 谢欢
2019-04-04 10:27 ` [PATCH] rtlwifi: move " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553049084.13542.2.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=chongguiguzi@gmail.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).