From: Pkshih <pkshih@realtek.com>
To: "yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static
Date: Wed, 20 Mar 2019 02:32:26 +0000 [thread overview]
Message-ID: <1553049147.13542.3.camel@realtek.com> (raw)
In-Reply-To: <20190319151927.19392-1-yuehaibing@huawei.com>
On Tue, 2019-03-19 at 23:19 +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c:666:6:
> warning: symbol 'rtl8723e_dm_refresh_rate_adaptive_mask' was not declared.
> Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
The mail subject should be 'rtlwifi: rtl8723ae: ....'.
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> index 514891e..d8260c7 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> @@ -663,7 +663,7 @@ void rtl8723e_dm_init_rate_adaptive_mask(struct
> ieee80211_hw *hw)
>
> }
>
> -void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
> +static void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
next prev parent reply other threads:[~2019-03-20 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 15:19 [PATCH] rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static Yue Haibing
2019-03-20 2:32 ` Pkshih [this message]
2019-04-13 11:18 ` [PATCH] rtlwifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553049147.13542.3.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).