From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F5AC43381 for ; Mon, 25 Mar 2019 15:55:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D25920896 for ; Mon, 25 Mar 2019 15:55:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729609AbfCYPzH (ORCPT ); Mon, 25 Mar 2019 11:55:07 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:38095 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728912AbfCYPzH (ORCPT ); Mon, 25 Mar 2019 11:55:07 -0400 Received: by mail-pg1-f194.google.com with SMTP id j26so4785914pgl.5 for ; Mon, 25 Mar 2019 08:55:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=AMujv5CprlBrbUDkQ1uDDGaPOSIejXKrkTaslogrhhg=; b=I7beDUXhj13gakCGJDz2ILfGFaWA7GMZio8/znaXXWTbCAHGTAaUVDZAfB5jIALFIa AvaTy1/Flmflo2+xpAGdQfSZEGpR8OZp5KCoIy2IAn6gzxq8AKThfL77NLxjcvbJGa1x PJBUsl9NKk6LWbZMj1hQuA18lqQyRSqCB9ppofMLZkZVrmndKLeg16q7gTXsDlRqjGju U9AkW5E4iNFEGyouwWdtDUiOulAPyldr9ZfpUWIAYzZltMGyHZl66dFMePk1+WP0b9zD g/9hJGX9pI7IKHgqjpfX5Sy9E3sDYcYoGkSe5PfmFRMAlk2fJsfsE0tHGTGwVlTRTB6W xcrg== X-Gm-Message-State: APjAAAXjKTltEaOJ/Ei6V7RnYuy0el5dPv3nbrcVur9FUz/KdTvjF++J xspeAqV/14YhPalgveqNeWA= X-Google-Smtp-Source: APXvYqxhJFGXWmhrNacitMZspwCzVl6V57q8BkwfbyikmTHQZyyLzmiCpfbdvM/qjy+uVXwnvZqOcQ== X-Received: by 2002:a65:63c1:: with SMTP id n1mr23762153pgv.339.1553529306892; Mon, 25 Mar 2019 08:55:06 -0700 (PDT) Received: from ?IPv6:2620:15c:2cd:203:5cdc:422c:7b28:ebb5? ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id p81sm19428588pfi.186.2019.03.25.08.55.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2019 08:55:06 -0700 (PDT) Message-ID: <1553529305.118779.8.camel@acm.org> Subject: Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it From: Bart Van Assche To: "Rustad, Mark D" Cc: David Miller , "netdev@vger.kernel.org" , Sagi Grimberg , Christoph Hellwig Date: Mon, 25 Mar 2019 08:55:05 -0700 In-Reply-To: <2C668AAE-BB6F-4292-84DD-25D4C6A5BC5F@intel.com> References: <20190321221946.163803-1-bvanassche@acm.org> <20190321221946.163803-8-bvanassche@acm.org> <2C668AAE-BB6F-4292-84DD-25D4C6A5BC5F@intel.com> Content-Type: text/plain; charset="UTF-7" X-Mailer: Evolution 3.26.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2019-03-22 at 18:46 +-0000, Rustad, Mark D wrote: +AD4 This doesn't look right to me. The original code seemingly would stop the +AD4 copy before getting to a possible '+ACU' character. The new code only stops at +AD4 eol. So this appears to change the functionality and I assume is broken in +AD4 any case that uses the +ACU. Take another look at what that min+AF8-t is really +AD4 doing. Hi Mark, Thanks for the feedback. I will drop this patch. Bart.