From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D7D0C43381 for ; Tue, 26 Mar 2019 17:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56BD620823 for ; Tue, 26 Mar 2019 17:11:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729693AbfCZRLh (ORCPT ); Tue, 26 Mar 2019 13:11:37 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:36503 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbfCZRLh (ORCPT ); Tue, 26 Mar 2019 13:11:37 -0400 Received: by mail-pl1-f194.google.com with SMTP id k2so1927857plt.3 for ; Tue, 26 Mar 2019 10:11:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=GfKQTcFXbaHUTWpgcz0P/A4d5LqdQwsnHlFur7zu1I8=; b=ueBd7dO5MjlPacBKGEn97LT7V3dDnkBGAfuc8UbHVLdkEXEzi7ZJ+qqZEzgpKWNDs5 8pdl/+JYyYm1KRqF0iV1aa7wKvdkw4RTSKCs7LQ6LE1FfJE+/tSG/dE+rbEny03h8vGb 4iSOiufLG+yZrMOAywlge/GLtzgjaHcW1AOrJpGUTOCAlczygDwFfHzfZ0+YKLA1hm3Z h1L0sbsOPlAmjIuRrmLqK1xWEBSTDbcvDYUFhWYHZZVgyHz9K9x00ys5lySDHYRaiIXz ddFw9p/nyJakTZa6+3tBWtWG3xQsM9/uxLMaDi2bDJh81oitzTCj81P0Z1Myw3GLxvs8 SUPA== X-Gm-Message-State: APjAAAWlxUEnIVwgFS60vw5idIaoe7ALo2FWnLekY2l2I9zMmnKGwoz1 43NwV2XHA1R2Tp8mIWjhBZOCLPExaok= X-Google-Smtp-Source: APXvYqyE4XQ5jV8AZojhdpUQQogLRuX2HNWjgSEIbi3XwkH3Tf8XDYgohhLYDnfzi1QGtPvzonOFag== X-Received: by 2002:a17:902:3f83:: with SMTP id a3mr30629082pld.6.1553620296290; Tue, 26 Mar 2019 10:11:36 -0700 (PDT) Received: from ?IPv6:2620:15c:2cd:203:5cdc:422c:7b28:ebb5? ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id l63sm28898421pfc.89.2019.03.26.10.11.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 10:11:35 -0700 (PDT) Message-ID: <1553620294.118779.64.camel@acm.org> Subject: Re: [PATCH v2 5/5] net/core: Allow the compiler to verify declaration and definition consistency From: Bart Van Assche To: Sabrina Dubroca Cc: David Miller , netdev@vger.kernel.org, Willem de Bruijn Date: Tue, 26 Mar 2019 10:11:34 -0700 In-Reply-To: <20190325182642.GA14636@bistromath.localdomain> References: <20190325161723.144556-1-bvanassche@acm.org> <20190325161723.144556-6-bvanassche@acm.org> <20190325182642.GA14636@bistromath.localdomain> Content-Type: text/plain; charset="UTF-7" X-Mailer: Evolution 3.26.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2019-03-25 at 19:26 +-0100, Sabrina Dubroca wrote: +AD4 2019-03-25, 09:17:23 -0700, Bart Van Assche wrote: +AD4 +AD4 diff --git a/net/core/datagram.h b/net/core/datagram.h +AD4 +AD4 new file mode 100644 +AD4 +AD4 index 000000000000..bcfb75bfa3b2 +AD4 +AD4 --- /dev/null +AD4 +AD4 +-+-+- b/net/core/datagram.h +AD4 +AD4 +AEAAQA -0,0 +-1,15 +AEAAQA +AD4 +AD4 +-/+ACo SPDX-License-Identifier: GPL-2.0 +ACo-/ +AD4 +AD4 +- +AD4 +AD4 +-+ACM-ifndef +AF8-NET+AF8-CORE+AF8-DATAGRAM+AF8-H+AF8 +AD4 +AD4 +-+ACM-define +AF8-NET+AF8-CORE+AF8-DATAGRAM+AF8-H+AF8 +AD4 +AD4 +- +AD4 +AD4 +-+ACM-include +ADw-linux/types.h+AD4 +AD4 +AD4 +- +AD4 +AD4 +-struct sock+ADs +AD4 +AD4 +-struct sk+AF8-buff+ADs +AD4 +AD4 +-struct iov+AF8-iter+ADs +AD4 +AD4 +- +AD4 +AD4 +-int +AF8AXw-zerocopy+AF8-sg+AF8-from+AF8-iter(struct sock +ACo-sk, struct sk+AF8-buff +ACo-skb, +AD4 +AD4 +- struct iov+AF8-iter +ACo-from, size+AF8-t length)+ADs +AD4 +AD4 +- +AD4 +AD4 +-+ACM-endif /+ACo +AF8-NET+AF8-CORE+AF8-DATAGRAM+AF8-H+AF8 +ACo-/ +AD4 +AD4 That's rather ugly. Could it just be moved to an appropriate file in +AD4 include/? Hi Sabrina, I think the convention in the Linux kernel is to keep header files with local declarations in the source code directory and only to declare functions that are used by other kernel components under include/. Do you think that the function +AF8AXw-zerocopy+AF8-sg+AF8-from+AF8-iter() will be needed by other kernel components? Thanks, Bart.