* [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count
@ 2019-04-03 21:57 William Tu
2019-04-03 21:57 ` [PATCH bpf 2/2] ixgbe: fix AF_XDP tx packet count William Tu
2019-04-04 0:13 ` [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count Daniel Borkmann
0 siblings, 2 replies; 4+ messages in thread
From: William Tu @ 2019-04-03 21:57 UTC (permalink / raw)
To: netdev, bjorn.topel, daniel, ast, magnus.karlsson
The tx bytecount is done twice. When running
'./xdpsock -t -N -i eth3' and 'ip -s link show dev eth3'
The avg packet size is 120 instead of 60. So remove the
extra one.
Signed-off-by: William Tu <u9012063@gmail.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
index bfe95ce0bd7f..71b8474a9b4c 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
@@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector,
xsk_frames++;
tx_bi->xdpf = NULL;
- total_bytes += tx_bi->bytecount;
tx_bi++;
tx_desc++;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH bpf 2/2] ixgbe: fix AF_XDP tx packet count.
2019-04-03 21:57 [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count William Tu
@ 2019-04-03 21:57 ` William Tu
2019-04-04 0:13 ` [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count Daniel Borkmann
1 sibling, 0 replies; 4+ messages in thread
From: William Tu @ 2019-04-03 21:57 UTC (permalink / raw)
To: netdev, bjorn.topel, daniel, ast, magnus.karlsson
The total_packets count at ixgbe_clean_xdp_tx_irq is
always zero when testing with xdpsock -t -N. Set the gso_segs
to 1 to make the tx packet count correct.
Signed-off-by: William Tu <u9012063@gmail.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
index 71b8474a9b4c..1a60764fb39b 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
@@ -640,6 +640,7 @@ static bool ixgbe_xmit_zc(struct ixgbe_ring *xdp_ring, unsigned int budget)
tx_bi = &xdp_ring->tx_buffer_info[xdp_ring->next_to_use];
tx_bi->bytecount = len;
tx_bi->xdpf = NULL;
+ tx_bi->gso_segs = 1;
tx_desc = IXGBE_TX_DESC(xdp_ring, xdp_ring->next_to_use);
tx_desc->read.buffer_addr = cpu_to_le64(dma);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count
2019-04-03 21:57 [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count William Tu
2019-04-03 21:57 ` [PATCH bpf 2/2] ixgbe: fix AF_XDP tx packet count William Tu
@ 2019-04-04 0:13 ` Daniel Borkmann
2019-04-04 3:41 ` Kirsher, Jeffrey T
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2019-04-04 0:13 UTC (permalink / raw)
To: William Tu, netdev, bjorn.topel, ast, magnus.karlsson,
jeffrey.t.kirsher
[ +Jeff ]
Given these two are contained to ixgbe, I presume Jeff wants to pick
these up instead via his tree?
On 04/03/2019 11:57 PM, William Tu wrote:
> The tx bytecount is done twice. When running
> './xdpsock -t -N -i eth3' and 'ip -s link show dev eth3'
> The avg packet size is 120 instead of 60. So remove the
> extra one.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
> index bfe95ce0bd7f..71b8474a9b4c 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
> @@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector,
> xsk_frames++;
>
> tx_bi->xdpf = NULL;
> - total_bytes += tx_bi->bytecount;
>
> tx_bi++;
> tx_desc++;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count
2019-04-04 0:13 ` [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count Daniel Borkmann
@ 2019-04-04 3:41 ` Kirsher, Jeffrey T
0 siblings, 0 replies; 4+ messages in thread
From: Kirsher, Jeffrey T @ 2019-04-04 3:41 UTC (permalink / raw)
To: Daniel Borkmann
Cc: William Tu, netdev@vger.kernel.org, Topel, Bjorn, ast@kernel.org,
Karlsson, Magnus
> On Apr 3, 2019, at 17:13, Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> [ +Jeff ]
>
> Given these two are contained to ixgbe, I presume Jeff wants to pick
> these up instead via his tree?
Yes, I will be picking them up.
>
>> On 04/03/2019 11:57 PM, William Tu wrote:
>> The tx bytecount is done twice. When running
>> './xdpsock -t -N -i eth3' and 'ip -s link show dev eth3'
>> The avg packet size is 120 instead of 60. So remove the
>> extra one.
>>
>> Signed-off-by: William Tu <u9012063@gmail.com>
>> ---
>> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
>> index bfe95ce0bd7f..71b8474a9b4c 100644
>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
>> @@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector,
>> xsk_frames++;
>>
>> tx_bi->xdpf = NULL;
>> - total_bytes += tx_bi->bytecount;
>>
>> tx_bi++;
>> tx_desc++;
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-04 3:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-03 21:57 [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count William Tu
2019-04-03 21:57 ` [PATCH bpf 2/2] ixgbe: fix AF_XDP tx packet count William Tu
2019-04-04 0:13 ` [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count Daniel Borkmann
2019-04-04 3:41 ` Kirsher, Jeffrey T
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).