From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 611BCC43219 for ; Fri, 26 Apr 2019 02:32:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4423D20685 for ; Fri, 26 Apr 2019 02:32:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="XUQjOryf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727183AbfDZCcF (ORCPT ); Thu, 25 Apr 2019 22:32:05 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:32800 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbfDZCcD (ORCPT ); Thu, 25 Apr 2019 22:32:03 -0400 Received: by mail-pg1-f194.google.com with SMTP id k19so836363pgh.0 for ; Thu, 25 Apr 2019 19:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=r/gT+1xmmR0Z5QGkQ6S7QsDbgMBJpLUz7aFU4PIPMe4=; b=XUQjOryfgMuCsYWKQvEeUJvaC9bPbmlDNh1a55ggV5m7U0z1Pfc+qUHqeETNWGVojL QkaYLSXOtPiAidahQxe5DR2fcjvo/WtDqoY8IAWrkjhf07ng1ygqyT69nx0REHLVL7MN No+ja+rhQiMN6iN3RSl69h5Op2aXmgFfu5J3A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=r/gT+1xmmR0Z5QGkQ6S7QsDbgMBJpLUz7aFU4PIPMe4=; b=pX7Mw4BhuTGIbTfSKkdZcBOCgIEM8O+Wb2sSEP4BGDm4GjIiAMUYmAvpgQfxHy93QZ k4zZhmgDS4rYRA/SzIVI9Zxs2pGGtuCINutKCAMHLodXfEEEW4gH48Efn/wuP5M5cIkl WGHy2FLDo1I5WT6XHrtCNfWar00tofanPvYneRiIp7gmf3yX2HV2BPHQ8/Hq2H2K+gH2 rAcmxTFRK7KSbfi6GjZXFyqXwORWOBVlWbsDepMi2dRrzkPrA3NWkUHStGRnHbadWf4V 9xnyT+UnBSXQMnxuZfxU13Tb/A0k8w1m4DnTjN29VVQnqbIbDhdeKq/ZdDlEkIs7J0sf upNg== X-Gm-Message-State: APjAAAVJ/addylcCuwvQvoZ9qKWXeOjP5Md03gGmIqgMDtlgrqJRaQ6y Coa1A2QzmIT6YWS+H5PpZWn1jQ== X-Google-Smtp-Source: APXvYqx+vjRd4k+GdcKW87IddnhyEc4KV+w/MZFT2PJj/fT+UHKYyIkaTADoR1c0+T03fKvuWFmhgQ== X-Received: by 2002:a65:47c6:: with SMTP id f6mr41236554pgs.173.1556245923098; Thu, 25 Apr 2019 19:32:03 -0700 (PDT) Received: from localhost.localdomain.dhcp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id n5sm25690368pgp.80.2019.04.25.19.32.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 19:32:02 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org Subject: [PATCH net 1/6] bnxt_en: Improve multicast address setup logic. Date: Thu, 25 Apr 2019 22:31:50 -0400 Message-Id: <1556245915-5430-2-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1556245915-5430-1-git-send-email-michael.chan@broadcom.com> References: <1556245915-5430-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver builds a list of multicast addresses and sends it to the firmware when the driver's ndo_set_rx_mode() is called. In rare cases, the firmware can fail this call if internal resources to add multicast addresses are exhausted. In that case, we should try the call again by setting the ALL_MCAST flag which is more guaranteed to succeed. Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 4c586ba..42fd273 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -8961,8 +8961,15 @@ static int bnxt_cfg_rx_mode(struct bnxt *bp) skip_uc: rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, 0); + if (rc && vnic->mc_list_count) { + netdev_info(bp->dev, "Failed setting MC filters rc: %d, turning on ALL_MCAST mode\n", + rc); + vnic->rx_mask |= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; + vnic->mc_list_count = 0; + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, 0); + } if (rc) - netdev_err(bp->dev, "HWRM cfa l2 rx mask failure rc: %x\n", + netdev_err(bp->dev, "HWRM cfa l2 rx mask failure rc: %d\n", rc); return rc; -- 2.5.1