From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0B6C43219 for ; Fri, 26 Apr 2019 02:32:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0536520685 for ; Fri, 26 Apr 2019 02:32:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cErg3xsO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727652AbfDZCcH (ORCPT ); Thu, 25 Apr 2019 22:32:07 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43530 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726429AbfDZCcF (ORCPT ); Thu, 25 Apr 2019 22:32:05 -0400 Received: by mail-pg1-f196.google.com with SMTP id z9so810028pgu.10 for ; Thu, 25 Apr 2019 19:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EZr1q4AxPiMm4+rfRWQeVe7BClJwfHWrpYXYUrcrPLM=; b=cErg3xsOcERqHbXdwhV9uqIF3X6RLPa5aP9rKdZ+qfOpnCGWkGALT5deG+43r+zTUn +Oq3UdN2ZkZWDPOROAGsb9N84++/cBvPjTliATc/XfzLcTEvd2DAr654w68Rfyiq+pi3 qzYw2InnEYggJZmP/38Y7v9kD3H8Pu7xrm5lE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EZr1q4AxPiMm4+rfRWQeVe7BClJwfHWrpYXYUrcrPLM=; b=HW4km6gqPPHl7avHBUnLg6qQ14jmcRDw9epdrNnK0R9ipCpU0EhH35l84a9sVmqBf6 6LYEOkAxFCkVm3y313AU01YvES4QSmHClDhVPYXLrIsIyWiKZglppdEmiEfxHhaGzPYv MyCOE1fVooQdq0CpQBMLl7ENjR47NKXhxB8kIYOMRFNDY35Wc9hRzaVkJCzn06pvu9p1 dYQrvHu22j6oYdRa1mvHQnCQWGjz9OgNn151zTjWqQ/EGTJVWBykHmEwcoUKPN0j6d2O T7LxzLEnozegvHKQTzsLRrSFVY1M9mG0Y8qnGMbRTkhGMrEY3VnaTqypfNBzE3hVB9D0 aAuw== X-Gm-Message-State: APjAAAVm8pttz0tu5tKZJ1wxLg80pG6N+n1B+uKE0Jwe3Bup2S73IiTj 23MpW4jauh3u4PY/2eOKX50EiHNgSWA= X-Google-Smtp-Source: APXvYqxs5xFAoS4RLyBbChJSmi0vJxcK4PM9wibaMVlD4WZmB5XjfFg4+biy+3LdKE9hLhId/1hoAw== X-Received: by 2002:a63:6983:: with SMTP id e125mr38294176pgc.370.1556245924284; Thu, 25 Apr 2019 19:32:04 -0700 (PDT) Received: from localhost.localdomain.dhcp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id n5sm25690368pgp.80.2019.04.25.19.32.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 19:32:03 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, Vasundhara Volam Subject: [PATCH net 2/6] bnxt_en: Free short FW command HWRM memory in error path in bnxt_init_one() Date: Thu, 25 Apr 2019 22:31:51 -0400 Message-Id: <1556245915-5430-3-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1556245915-5430-1-git-send-email-michael.chan@broadcom.com> References: <1556245915-5430-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vasundhara Volam In the bnxt_init_one() error path, short FW command request memory is not freed. This patch fixes it. Fixes: e605db801bde ("bnxt_en: Support for Short Firmware Message") Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 42fd273..5d02f59 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -10692,6 +10692,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) bnxt_clear_int_mode(bp); init_err_pci_clean: + bnxt_free_hwrm_short_cmd_req(bp); bnxt_free_hwrm_resources(bp); bnxt_free_ctx_mem(bp); kfree(bp->ctx); -- 2.5.1