From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: santosh.shilimkar@oracle.com
Subject: [net-next][PATCH v2 1/2] rds: handle unsupported rdma request to fs dax memory
Date: Mon, 29 Apr 2019 16:37:19 -0700 [thread overview]
Message-ID: <1556581040-4812-2-git-send-email-santosh.shilimkar@oracle.com> (raw)
In-Reply-To: <1556581040-4812-1-git-send-email-santosh.shilimkar@oracle.com>
From: Hans Westgaard Ry <hans.westgaard.ry@oracle.com>
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. User applications can try to use
RDS to perform RDMA over such memories and since it doesn't report any
failure, it can lead to unexpected issues like memory corruption when
a couple of out of sync file system operations like ftruncate etc. are
performed.
The patch adds a check so that such an attempt to RDMA to/from memory
apertures requiring ODP will fail.
Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
Reviewed-tested-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Signed-off-by: Hans Westgaard Ry <hans.westgaard.ry@oracle.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
---
net/rds/rdma.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index 182ab84..e0a6b72 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -158,8 +158,9 @@ static int rds_pin_pages(unsigned long user_addr, unsigned int nr_pages,
{
int ret;
- ret = get_user_pages_fast(user_addr, nr_pages, write, pages);
-
+ /* get_user_pages return -EOPNOTSUPP for fs_dax memory */
+ ret = get_user_pages_longterm(user_addr, nr_pages,
+ write, pages, NULL);
if (ret >= 0 && ret < nr_pages) {
while (ret--)
put_page(pages[ret]);
--
1.9.1
next prev parent reply other threads:[~2019-04-29 23:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 23:37 [net-next][PATCH v2 0/2] rds: handle unsupported rdma request to fs dax memory Santosh Shilimkar
2019-04-29 23:37 ` Santosh Shilimkar [this message]
2019-05-01 7:44 ` [net-next][PATCH v2 1/2] " Leon Romanovsky
2019-05-01 17:54 ` Santosh Shilimkar
2019-05-02 6:21 ` Leon Romanovsky
2019-05-02 17:52 ` Santosh Shilimkar
2019-05-05 6:28 ` Leon Romanovsky
2019-05-06 16:39 ` Santosh Shilimkar
2019-05-10 12:54 ` Jason Gunthorpe
2019-05-10 16:11 ` Santosh Shilimkar
2019-05-10 17:55 ` Jason Gunthorpe
2019-05-10 18:02 ` santosh.shilimkar
2019-05-10 18:07 ` Jason Gunthorpe
2019-05-10 18:58 ` santosh.shilimkar
2019-05-10 19:20 ` Jason Gunthorpe
2019-05-10 19:38 ` Santosh Shilimkar
2019-05-10 19:47 ` Jason Gunthorpe
2019-05-10 20:12 ` Santosh Shilimkar
2019-05-10 20:39 ` Jason Gunthorpe
2019-04-29 23:37 ` [net-next][PATCH v2 2/2] rds: add sysctl for rds support of On-Demand-Paging Santosh Shilimkar
2019-05-01 7:45 ` Leon Romanovsky
2019-05-01 17:54 ` Santosh Shilimkar
2019-05-02 6:18 ` Leon Romanovsky
2019-05-02 17:59 ` Santosh Shilimkar
2019-05-05 6:22 ` Leon Romanovsky
2019-05-06 16:37 ` Santosh Shilimkar
2019-05-10 13:02 ` Jason Gunthorpe
2019-05-10 16:13 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556581040-4812-2-git-send-email-santosh.shilimkar@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).